Fix: Transporter dangling psActionTarget references #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a transporter returns to home base (from an active away mission), it is moved offworld by `orderUpdateDroid()`. (Its properties are reset by `missionMoveTransporterOffWorld()` and it is moved to the mission list, with its action set to `DACTION_NONE`.) The subsequent call to `actionUpdateDroid()` inside `droidUpdate()` could then set the transporter's `psActionTarget` to a remaining enemy structure / unit on the away mission map - despite the fact that it had already been moved "off world". To fix this, skip further processing of the droid inside `droidUpdate()` when `orderUpdateDroid()` returns false (as an indicator that the droid has been moved from its current list).
past-due
force-pushed
the
2024_07_fix_transporter_dangling_refs_1
branch
from
f1b880e
to
afce98e
Compare
ManManson
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a transporter returns to home base (from an active away mission), it is moved offworld by
orderUpdateDroid(). (Its properties are reset bymissionMoveTransporterOffWorld()and it is moved to the mission list, with its action set toDACTION_NONE.)The subsequent call to
actionUpdateDroid()insidedroidUpdate()could then set the transporter'spsActionTargetto a remaining enemy structure / unit on the away mission map - despite the fact that it had already been moved "off world".To fix this, skip further processing of the droid inside
droidUpdate()whenorderUpdateDroid()returns false (as an indicator that the droid has been moved from its current list).