Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Transporter dangling psActionTarget references #3959

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Fix: Transporter dangling psActionTarget references #3959

merged 2 commits into from
Jul 2, 2024

Commits on Jul 2, 2024

  1. Fix: Transporter dangling psActionTarget references 

    When a transporter returns to home base (from an active away mission), it is moved offworld by `orderUpdateDroid()`. (Its properties are reset by `missionMoveTransporterOffWorld()` and it is moved to the mission list, with its action set to `DACTION_NONE`.)

The subsequent call to `actionUpdateDroid()` inside `droidUpdate()` could then set the transporter's `psActionTarget` to a remaining enemy structure / unit on the away mission map - despite the fact that it had already been moved "off world".

To fix this, skip further processing of the droid inside `droidUpdate()` when `orderUpdateDroid()` returns false (as an indicator that the droid has been moved from its current list).
    @past-due
    past-due committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    bcf421b View commit details
    Browse the repository at this point in the history

  2. clparse.cpp: Remove old macOS-only code

    @past-due
    past-due committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    afce98e View commit details
    Browse the repository at this point in the history