[js-api] Re-add old tests to test/js-api/exception #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two tests used to be in https://github.com/WebAssembly/exception-handling/tree/main/test/js-api/exception and were moved into https://github.com/WebAssembly/exception-handling/tree/main/test/legacy/exceptions/js-api in #305. I'm planning new version of these tests that use `try_table` and `throw_ref` in https://github.com/WebAssembly/exception-handling/tree/main/test/js-api/exception, but it wouldn't require to rewrite the whole tests, but copying these tests into the this directory and modify them in a single PR makes Github think these are brand-new files, resulting in a large diff containing the whole files that is difficult to review (and which has been reviewed and in the repo for a long time already). So I'm making a PR that only re-adds these file here so that I can add changes to these files in another PR.
dschuff
approved these changes
Jun 21, 2024
Ms2ger
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two tests used to be in
https://github.com/WebAssembly/exception-handling/tree/main/test/js-api/exception and were moved into
https://github.com/WebAssembly/exception-handling/tree/main/test/legacy/exceptions/js-api in #305.
I'm planning new version of these tests that use
try_tableandthrow_refinhttps://github.com/WebAssembly/exception-handling/tree/main/test/js-api/exception, but it wouldn't require to rewrite the whole tests, but copying these tests into the this directory and modify them in a single PR makes Github think these are brand-new files, resulting in a large diff containing the whole files that is difficult to review (and which has been reviewed and in the repo for a long time already).
So I'm making a PR that only re-adds these file here so that I can add changes to these files in another PR.