New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js-api] Re-add old tests to test/js-api/exception #315

Merged

aheejin merged 1 commit into main from restore_old_tests

Jun 25, 2024

Commits on Jun 21, 2024

[js-api] Re-add old tests to test/js-api/exception

These two tests used to be in
https://github.com/WebAssembly/exception-handling/tree/main/test/js-api/exception
and were moved into
https://github.com/WebAssembly/exception-handling/tree/main/test/legacy/exceptions/js-api
in #305.

I'm planning new version of these tests that use `try_table` and
`throw_ref` in
https://github.com/WebAssembly/exception-handling/tree/main/test/js-api/exception,
but it wouldn't require to rewrite the whole tests, but copying these
tests into the this directory and modify them in a single PR makes
Github think these are brand-new files, resulting in a large diff
containing the whole files that is difficult to review (and which has
been reviewed and in the repo for a long time already).

So I'm making a PR that only re-adds these file here so that I can add
changes to these files in another PR.

aheejin committed Jun 21, 2024