알림 팝오버에 스켈레톤 UI 적용 #244
Merged
알림 팝오버에 스켈레톤 UI 적용 #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthrough알림 팝오버의 로딩 UI가 텍스트에서 스켈레톤 플레이스홀더로 교체되었습니다. NotificationCardSkeleton 컴포넌트가 새로 추가되어 디자인 시스템에 포함되었고, NotificationCard의 클릭 이벤트 처리 방식이 통합 및 개선되었습니다. 여러 파일에서 관련 컴포넌트의 임포트 및 사용이 반영되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant NotificationPopover
participant NotificationCardSkeleton
participant NotificationCard
User->>NotificationPopover: 팝오버 열기
NotificationPopover->>NotificationPopover: isLoading 확인
alt isLoading == true
NotificationPopover->>NotificationCardSkeleton: 4개 렌더링
else isLoading == false
NotificationPopover->>NotificationCard: 알림 목록 렌더링
NotificationPopover->>NotificationCardSkeleton: isFetchingNextPage 시 1개 렌더링
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. 📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
|
🚀 오늘뭐해 Preview Deploy 완료! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Closed
|
🚀 오늘뭐해 Preview Deploy 완료! |
HarrySeop
approved these changes
Aug 4, 2025
Member
HarrySeop
left a comment
HarrySeop
left a comment
There was a problem hiding this comment.
고생하셧습니다! 스타일 관련해서 리뷰 남겨놨습니다! 확인 부탁드려요!
| </div> | ||
| <Button className='h-fit w-fit p-0' variant='none' onClick={onDelete}> | ||
| <Button | ||
| className='h-fit w-fit p-0' |
Member
There was a problem hiding this comment.
size='none' 사용하시면 className='h-fit w-fit p-0' 대체 됩니다! 혹시나 위에 95번째줄 라인 반영하시면 같이 수정 부탁드려요!
Contributor
Author
There was a problem hiding this comment.
className을 빼면 사진과 같이 스타일이 깨져서 이 부분은 그대로 두었습니다..!
|
🚀 오늘뭐해 Preview Deploy 완료! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧩 관련 이슈 번호
📌 작업 내용
✅ 체크리스트
📷 UI 변경 사항 (선택)
❓무슨 문제가 발생했나요? (선택)
💬 기타 참고 사항 (선택)
Summary by CodeRabbit
New Features
버그 수정
스타일
문서화