-
Notifications
You must be signed in to change notification settings - Fork 1
알림 팝오버에 스켈레톤 UI 적용 #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
알림 팝오버에 스켈레톤 UI 적용 #244
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
6b40eed
♻️ [#239] Refactor: 예약 내역 페이지로 이동하는 영역을 알림 카드 영역 전체로 확대
MyungJiwoo 2895765
✨ [#239] Feat: NotificationCard의 스켈레톤 UI 구현
MyungJiwoo ba301f5
✨ [#239] Feat: 알림 팝오버 내에 스켈레톤 UI 적용
MyungJiwoo a33ddd7
🐛 [#239] Fix: 알림 무한스크롤 요청 size 원상복구
MyungJiwoo c1d21ab
♻️ [#239] Refactor: UI 일관성 리팩토링
MyungJiwoo c221c68
🐛 [#239] Fix: text-gray-950 제거
MyungJiwoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 changes: 26 additions & 0 deletions
26
packages/design-system/src/components/skeleton/NotificationCardSkeleton.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| export default function NotificationCardSkeleton() { | ||
| return ( | ||
| <div className='text-md flex animate-pulse cursor-pointer flex-col gap-4 p-16 md:gap-8'> | ||
| {/* 상단: 상태 뱃지 + 문구 + 삭제 버튼 */} | ||
| <div className='flex items-center justify-between'> | ||
| <div className='flex items-center gap-8'> | ||
| <div className='h-26 w-60 rounded-full bg-gray-100' /> | ||
| <div className='my-2 h-22 w-100 rounded bg-gray-100' /> | ||
| </div> | ||
| <div className='size-22 animate-pulse rounded-full bg-gray-100' /> | ||
| </div> | ||
|
|
||
| {/* 제목 (아이콘 + 텍스트) */} | ||
| <div className='my-2 flex items-center gap-4'> | ||
| <div className='size-16 rounded-full bg-gray-100' /> | ||
| <div className='h-20 w-full max-w-[200px] rounded bg-gray-100' /> | ||
| </div> | ||
|
|
||
| {/* 날짜 및 시간 (아이콘 + 텍스트) */} | ||
| <div className='my-2 flex items-center gap-4'> | ||
| <div className='size-16 rounded-full bg-gray-100' /> | ||
| <div className='h-20 w-full max-w-[170px] rounded bg-gray-100' /> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| export { default as ExperienceCardSkeleton } from './ExperienceCardSkeleton'; | ||
| export { default as NotificationCardSkeleton } from './NotificationCardSkeleton'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
size='none' 사용하시면
className='h-fit w-fit p-0'대체 됩니다! 혹시나 위에 95번째줄 라인 반영하시면 같이 수정 부탁드려요!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
className을 빼면 사진과 같이 스타일이 깨져서 이 부분은 그대로 두었습니다..!