Merge pull request #572 from WildernessLabs/bug/provision

make device ID upper case on provisioning
WildernessLabs · May 26, 2024 · 3be3c3a · 3be3c3a
2 parents 65d96ac + d261c30
commit 3be3c3a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/Source/v2/Meadow.Cli/Commands/Current/App/AppDeployCommand.cs b/Source/v2/Meadow.Cli/Commands/Current/App/AppDeployCommand.cs
@@ -5,7 +5,7 @@
 
 namespace Meadow.CLI.Commands.DeviceManagement;
 
-[Command("app deploy", Description = "Deploy a compiled Meadow application to a target device")]
+[Command("app deploy", Description = "Deploys a previously compiled Meadow application to a target device. Note: This command does not compile the application.")]
 public class AppDeployCommand : BaseDeviceCommand<AppDeployCommand>
 {
     private readonly IPackageManager _packageManager;

diff --git a/Source/v2/Meadow.Cli/Commands/Current/Device/DeviceProvisionCommand.cs b/Source/v2/Meadow.Cli/Commands/Current/Device/DeviceProvisionCommand.cs
@@ -123,7 +123,7 @@ protected override async ValueTask ExecuteCommand()
             {
                 throw new CommandException("If a public key is provided, an `id` must also be provided");
             }
-            provisioningID = SerialNumber.ToUpper();
+            provisioningID = SerialNumber;
             provisioningName = Name ?? string.Empty;
         }
         else
@@ -176,7 +176,9 @@ protected override async ValueTask ExecuteCommand()
 
         Logger?.LogInformation(Strings.ProvisioningWithCloud);
 
-        var result = await _deviceService.AddDevice(org.Id!, provisioningID!, PublicKey, CollectionId, provisioningName, Host, CancellationToken);
+        provisioningID = provisioningID!.ToUpper();
+
+        var result = await _deviceService.AddDevice(org.Id!, provisioningID, PublicKey, CollectionId, provisioningName, Host, CancellationToken);
 
         if (result.isSuccess)
         {