Updated how result codes are interrogated

Yuck · Jan 22, 2022 · 64cab1e · 64cab1e
1 parent b930dbb
commit 64cab1e
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 7 deletions.
diff --git a/src/YuckQi.Domain.Services/YuckQi.Domain.Services.csproj b/src/YuckQi.Domain.Services/YuckQi.Domain.Services.csproj
@@ -4,7 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Authors>Kevin J Lambert</Authors>
-    <Version>1.2.0</Version>
+    <Version>1.3.0</Version>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
     <Description>A .NET library for bootstrapping a domain services project.</Description>
   </PropertyGroup>

diff --git a/src/YuckQi.Domain.Validation/Result.cs b/src/YuckQi.Domain.Validation/Result.cs
@@ -36,7 +36,9 @@ public class Result<T> : Result
 
         #region Constructors
 
-        public Result(ResultDetail detail) : base(new List<ResultDetail> { detail }) { }
+        public Result(ResultDetail detail) : this(new List<ResultDetail> { detail }) { }
+
+        public Result(IReadOnlyCollection<ResultDetail> detail) : base(detail) { }
 
         public Result(T payload, IReadOnlyCollection<ResultDetail> detail = null) : base(detail)
         {
@@ -50,9 +52,7 @@ public Result(T payload, IReadOnlyCollection<ResultDetail> detail = null) : base
 
         public static Result<T> ConstraintViolation<TKey>(TKey key, String message = null) where TKey : struct => new Result<T>(ResultDetail.ConstraintViolation<T, TKey>(key, message));
 
-        public Boolean IsConstraintViolation => Detail.Any(t => String.Equals(t.Code, ResultCode.ConstraintViolation));
-
-        public Boolean IsNotFound => Detail.Any(t => String.Equals(t.Code, ResultCode.NotFound));
+        public Boolean HasResultCode(ResultCode resultCode) => Detail.Any(t => t.Code == resultCode);
 
         public static Result<T> NotFound<TKey>(TKey key, String message = null) where TKey : struct => new Result<T>(ResultDetail.NotFound<T, TKey>(key, message));
 

diff --git a/src/YuckQi.Domain.Validation/YuckQi.Domain.Validation.csproj b/src/YuckQi.Domain.Validation/YuckQi.Domain.Validation.csproj
@@ -4,7 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Authors>Kevin J Lambert</Authors>
-    <Version>1.2.0</Version>
+    <Version>1.3.0</Version>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
     <Description>A .NET library providing domain validation fundamentals.</Description>
   </PropertyGroup>

diff --git a/src/YuckQi.Domain/YuckQi.Domain.csproj b/src/YuckQi.Domain/YuckQi.Domain.csproj
@@ -4,7 +4,7 @@
     <TargetFramework>netstandard2.0</TargetFramework>
     <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
     <Authors>Kevin J Lambert</Authors>
-    <Version>1.2.0</Version>
+    <Version>1.3.0</Version>
     <PackageLicenseFile>LICENSE</PackageLicenseFile>
     <Description>A .NET library for bootstrapping a domain model project.</Description>
   </PropertyGroup>

diff --git a/test/YuckQi.Domain.Validation.UnitTests/ResultTests.cs b/test/YuckQi.Domain.Validation.UnitTests/ResultTests.cs
@@ -9,6 +9,16 @@ public class ResultTests
     [SetUp]
     public void Setup() { }
 
+    [Test]
+    public void Result_NotFound_HasNotFoundResultCode()
+    {
+        var detail = new List<ResultDetail> { ResultDetail.NotFound<String, Int32>(1), ResultDetail.ConstraintViolation<String, Int32>(1) }.AsReadOnly();
+        var result = new Result<String>(detail);
+        var hasNotFoundResultCode = result.HasResultCode(ResultCode.NotFound);
+
+        Assert.IsTrue(hasNotFoundResultCode);
+    }
+
     [Test]
     public void Result_WithErrors_IsNotValid()
     {