feat(angular): angular renderer api symmetry for custom catalogs - #2060
Open
josemontespg wants to merge 8 commits into
Open
feat(angular): angular renderer api symmetry for custom catalogs#2060josemontespg wants to merge 8 commits into
josemontespg wants to merge 8 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request deprecates extraComponents in BasicCatalogOptions, introduces the createAngularComponentImplementation helper function, and adds corresponding unit tests. The feedback suggests using the spread operator (...api) in the helper function to ensure any future properties on ComponentApi are preserved.
josemontespg
commented
Jul 21, 2026
josemontespg
left a comment
josemontespg
left a comment
Collaborator
Author
There was a problem hiding this comment.
Adversarial review passed.
ditman
reviewed
Jul 21, 2026
ditman
reviewed
Jul 22, 2026
ditman
left a comment
ditman
left a comment
Collaborator
There was a problem hiding this comment.
The new API looks good to me, but I think we can do better on the examples/docs maybe? PS: do we have anything that can be improved by this new APIs in the sample apps, for example?
…d changelog for deprecated options
josemontespg
commented
Jul 27, 2026
josemontespg
commented
Jul 27, 2026
…entation helper and add JSDoc
josemontespg
commented
Jul 27, 2026
…nentImplementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Introduced
createComponentImplementationhelper inrenderers/angular/src/v0_9/catalog/types.ts.Deprecate
extraComponentsandfunctionsinBasicCatalogOptionswithinrenderers/angular/src/v0_9/catalog/basic/basic-catalog.tsin favor of direct instantiation ofAngularCatalogto combineBASIC_COMPONENTSandBASIC_FUNCTIONSwith custom ones.Why
Resolves #2001. Align the Angular Renderer Catalog API with the Web Core and React implementations to provide a symmetric and cleaner way of defining custom catalogs.
Effect
Allows Angular users to register custom components and functions using a pattern that matches the core implementation, and encourages cleaner catalog creation. Fully backward compatible; existing
extraComponentsandfunctionsusage is deprecated but still functions.