-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(angular): angular renderer api symmetry for custom catalogs #2060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
josemontespg
wants to merge
8
commits into
a2ui-project:main
Choose a base branch
from
josemontespg:agent/wt_e8747203
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
499bc30
feat(angular): implement Catalog API symmetry and deprecate extraComp…
josemontespg eb0106c
chore: format types.ts
josemontespg 7504c82
docs(angular): update CHANGELOG for PR 2060
josemontespg 5f57612
feat(angular): deprecate functions in BasicCatalogOptions
josemontespg 17674de
Address PR comments: use CatalogComponent in tests, update samples an…
josemontespg 904d117
docs(angular): remove migration guide from CHANGELOG
josemontespg 0b9bdd8
Refactor basic catalog components to use createAngularComponentImplem…
josemontespg f258321
Implement: Rename createAngularComponentImplementation to createCompo…
josemontespg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| /** | ||
| * Copyright 2026 Google LLC | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| import {Component, signal} from '@angular/core'; | ||
| import {ComponentApi} from '@a2ui/web_core/v0_9'; | ||
| import {createAngularComponentImplementation} from './types'; | ||
| import {CatalogComponentInstance} from '../core/catalog_component_instance'; | ||
| import {z} from 'zod'; | ||
|
|
||
| @Component({ | ||
| selector: 'test-comp', | ||
| template: '', | ||
| standalone: true, | ||
| }) | ||
| class TestComponent implements CatalogComponentInstance { | ||
| readonly props = signal<Record<string, unknown>>({}); | ||
| readonly surfaceId = signal(''); | ||
| readonly componentId = signal(''); | ||
| readonly dataContextPath = signal(''); | ||
| } | ||
|
|
||
| describe('createAngularComponentImplementation', () => { | ||
| it('should map ComponentApi and Angular Component Type correctly', () => { | ||
| const api: ComponentApi = { | ||
| name: 'TestComp', | ||
| schema: z.object({}), | ||
| }; | ||
|
|
||
| const impl = createAngularComponentImplementation(api, TestComponent); | ||
|
|
||
| expect(impl.name).toBe('TestComp'); | ||
| expect(impl.schema).toEqual(api.schema); | ||
| expect(impl.component).toBe(TestComponent); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.