fix(spec): require actionId when an action wants a response#2072
Open
BBC6BAE9 wants to merge 1 commit into
Open
fix(spec): require actionId when an action wants a response#2072BBC6BAE9 wants to merge 1 commit into
BBC6BAE9 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the JSON schema in client_to_server.json to conditionally require actionId when wantResponse is set to true. It also adds test cases in client_messages.json to validate this new schema constraint. I have no feedback to provide.
BBC6BAE9
force-pushed
the
fix/v1-action-id-schema
branch
from
July 23, 2026 06:22
5fdb0d3 to
f766da9
Compare
BBC6BAE9
force-pushed
the
fix/v1-action-id-schema
branch
from
July 23, 2026 06:35
f766da9 to
1b8f885
Compare
Collaborator
|
Thank you for your contribution. Unfortunately, we must decline this PR at this time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Require
actionIdwhen a v1.0 renderer action explicitly setswantResponsetotrue, and add schema cases covering response-requesting and fire-and-forget actions.The v1.0 protocol documentation already states that
actionIdis required in this case, butrenderer_to_agent.jsondid not encode the conditional requirement. As a result, the schema accepted response-requesting actions that an agent could not correlate with anactionResponse.The condition also requires
wantResponseitself to be present, so existing actions that omit the optional field continue to validate. No tracking issue was filed because this is a small schema consistency fix.Impact
wantResponseremain valid.wantResponse: falseremain valid without anactionId.wantResponse: truemust include anactionId.Validation
python3 specification/v1_0/test/run_tests.py— 138 passed, 0 failedpython3 specification/scripts/validate.py— Overall Validation: PASSEDgit diff --check— passedPre-launch Checklist
One time:
For this PR:
GEMINI_API_KEYand is unrelated to the schema-only change.If you need help, consider asking for advice on the discussion board.