Skip to content

fix(spec): require actionId when an action wants a response #2072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BBC6BAE9 wants to merge 2 commits into
base: main
Choose a base branch
from
+68 −1
Open

fix(spec): require actionId when an action wants a response #2072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b8f885
fix(spec): require actionId when an action wants a response
BBC6BAE9 Jul 22, 2026
e29c7c1
Merge branch 'main' into fix/v1-action-id-schema
BBC6BAE9 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion specification/v1_0/json/renderer_to_agent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,22 @@
"description": "Unique ID for this action call. Only needed if wantResponse is true."
}
},
"required": ["name", "surfaceId", "sourceComponentId", "timestamp", "context"]
"required": ["name", "surfaceId", "sourceComponentId", "timestamp", "context"],
"allOf": [
{
"if": {
"properties": {
"wantResponse": {
"const": true
}
},
"required": ["wantResponse"]
},
"then": {
"required": ["actionId"]
}
}
]
},
"functionResponse": {
"properties": {
Expand Down
52 changes: 52 additions & 0 deletions specification/v1_0/test/cases/renderer_messages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,58 @@
}
}
},
{
"description": "Valid action requesting a response with an actionId",
"valid": true,
"data": {
"version": "v1.0",
"action": {
"name": "submit",
"surfaceId": "main",
"sourceComponentId": "btn_submit",
"timestamp": "2023-10-27T10:00:00Z",
"context": {
"foo": "bar"
},
"wantResponse": true,
"actionId": "submit-1"
}
}
},
{
"description": "Invalid action requesting a response without an actionId",
"valid": false,
"data": {
"version": "v1.0",
"action": {
"name": "submit",
"surfaceId": "main",
"sourceComponentId": "btn_submit",
"timestamp": "2023-10-27T10:00:00Z",
"context": {
"foo": "bar"
},
"wantResponse": true
}
}
},
{
"description": "Valid action not requesting a response without an actionId",
"valid": true,
"data": {
"version": "v1.0",
"action": {
"name": "submit",
"surfaceId": "main",
"sourceComponentId": "btn_submit",
"timestamp": "2023-10-27T10:00:00Z",
"context": {
"foo": "bar"
},
"wantResponse": false
}
}
},
{
"description": "Valid error message (validation failed)",
"valid": true,
Expand Down
Loading