Skip to content

Fix Chinese i18n: remove Japanese text + improve translations (#789)#790

Merged
ChuxiJ merged 1 commit intomainfrom
fix/issue-789-chinese-i18n
Mar 7, 2026
Merged

Fix Chinese i18n: remove Japanese text + improve translations (#789)#790
ChuxiJ merged 1 commit intomainfrom
fix/issue-789-chinese-i18n

Conversation

@ChuxiJ
Copy link
Contributor

@ChuxiJ ChuxiJ commented Mar 7, 2026

Summary

This PR fixes the Chinese localization issues reported in #789:

Changes Made

  1. Removed Japanese text leak (lines 184-185)

    • cot_metas_label: "CoT メタデータ" → "CoT 元数据"
    • cot_metas_info: Japanese sentence → proper Chinese translation
  2. Improved terminology

    • app.title: "演练场" → "游乐场" (Playground - more natural Chinese)
    • offload_cpu_label: "卸载到CPU" → "闲置时转移到 CPU" (clearer meaning)
    • offload_dit_cpu_label: "将DiT卸载到CPU" → "将DiT转移到CPU" (consistency)
    • Help text: "设置手风琴" → "设置面板" (Settings panel - more appropriate)
  3. Consistency updates

    • Updated all references to CPU offload terminology throughout the file

Regarding Language Switcher Issue

The language switcher appearing locked is a separate issue from the translation quality. After investigating the code:

  • The UI component is already set to interactive=True in generation_service_config_rows.py
  • The dropdown should be functional, but there may be missing event handlers
  • This requires further investigation into the event wiring system

I've focused this PR on fixing the translation quality issues as they are independent of the UI interaction problem.

Testing

  • Verified JSON syntax is valid
  • Confirmed all Chinese text is properly encoded
  • Checked consistency of terminology throughout the file

Closes #789

Summary by CodeRabbit

  • Chores
    • Updated Chinese translations to enhance consistency and clarity across UI labels, configuration descriptions, and help documentation.

Changes:
- Remove Japanese text leak in CoT metadata labels (lines 184-185)
- Change "演练场" to "游乐场" (Playground) in app title
- Improve "卸载到CPU" to "闲置时转移到 CPU" for better clarity
- Change "设置手风琴" to "设置面板" (Settings panel) in help text
- Update related references for consistency

Fixes #789

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 7, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 12e4dfcb-0049-4797-9d05-a08fbaa08a4d

📥 Commits

Reviewing files that changed from the base of the PR and between edc950b and 21117a4.

📒 Files selected for processing (1)
  • acestep/ui/gradio/i18n/zh.json

📝 Walkthrough

Walkthrough

Chinese language translations in the UI have been corrected and refined. Changes include replacing Japanese text that leaked into the file, adjusting terminology for clarity (e.g., "游乐场" for playground, "闲置时转移到 CPU" for CPU offload behavior), and standardizing UI labels across help sections.

Changes

Cohort / File(s) Summary
Chinese Translation Updates
acestep/ui/gradio/i18n/zh.json
Corrected Japanese text in CoT metadata labels, refined terminology for CPU offload behavior, updated app title, standardized help section wording, and improved semantic clarity in generation-related descriptions. No fields added or removed; logic and control flow unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A little hop through phrases bright,
Japanese ghosts now set to flight,
"演练场" bows to "游乐场"'s call,
Chinese words bloom straight and tall! 🎨✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/issue-789-chinese-i18n

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ChuxiJ ChuxiJ merged commit 7e654eb into main Mar 7, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[i18n] Chinese UI improvements: language switcher + translation fixes

1 participant