Fix Chinese i18n: remove Japanese text + improve translations (#789)#790
Fix Chinese i18n: remove Japanese text + improve translations (#789)#790
Conversation
Changes: - Remove Japanese text leak in CoT metadata labels (lines 184-185) - Change "演练场" to "游乐场" (Playground) in app title - Improve "卸载到CPU" to "闲置时转移到 CPU" for better clarity - Change "设置手风琴" to "设置面板" (Settings panel) in help text - Update related references for consistency Fixes #789 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChinese language translations in the UI have been corrected and refined. Changes include replacing Japanese text that leaked into the file, adjusting terminology for clarity (e.g., "游乐场" for playground, "闲置时转移到 CPU" for CPU offload behavior), and standardizing UI labels across help sections. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
This PR fixes the Chinese localization issues reported in #789:
Changes Made
Removed Japanese text leak (lines 184-185)
cot_metas_label: "CoT メタデータ" → "CoT 元数据"cot_metas_info: Japanese sentence → proper Chinese translationImproved terminology
app.title: "演练场" → "游乐场" (Playground - more natural Chinese)offload_cpu_label: "卸载到CPU" → "闲置时转移到 CPU" (clearer meaning)offload_dit_cpu_label: "将DiT卸载到CPU" → "将DiT转移到CPU" (consistency)Consistency updates
Regarding Language Switcher Issue
The language switcher appearing locked is a separate issue from the translation quality. After investigating the code:
interactive=Trueingeneration_service_config_rows.pyI've focused this PR on fixing the translation quality issues as they are independent of the UI interaction problem.
Testing
Closes #789
Summary by CodeRabbit