-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement profile page #117
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I would remove the edit button in the about section since it goes to the same place |
Fun challenge for later: customizing the pink background per user so everyone's looks different my idea was that you take their past attendances and proportionally use each of the community colors that they're engaged with in some kind of randomly generated blobs or patterns so the background represents them and it could change every time they attend a new event |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some visual nits as comments in addition to these code comments. code looks excellent very clean and readable and the page also looks great excellent work 🤩
Co-authored-by: Faris Ashai <[email protected]>
Messing with having the the second edit button link to directly editing the 'About me' section, thoughts? |
Implemented some changes in latest commit 8a0198f but I want to update icons also soon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of tiny nits but amazing work overall 🎉 code quality is very clean and thoughtful and the UI is in great shape
Closes #33 |
Info
Closes #29
Description
Implements the user profile page.
Note: the original profile page branch died and wouldn't deploy, possibly because it's too old or something 🤷
Changes
/profile
redirects to/u/[user_handle]
UserProfilePage
component which renders a user profile pageHandleNotFound
component which tells users a handle does not exist/u/[handle]
which retrieves the current user, the handle's user, and their attendances, then renders the correct componentutils.js
functionsgetUserRank()
andhashUser()
with their real functionalityGifSafeImage
component which automatically makes next/image Images unoptimized whensrc
is a gifwidth
andheight
attributes from some svgs so they can be used at different sizes on this PR; existing usages have (hopefully) all been updated to manually set the size/constants/majors.json
refactored to a.ts
fileType of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
src/lib
functions and commented hard to understand areasanywhere else.
Screenshots
desktop- own profile - light mode
desktop- other's profile - light mode
mobile - other's profile - dark mode
handle not found - dark mode