Fix: Assign block tracking IDs via an atomic counter#37
Merged
Conversation
insertTrackingId previously read the current max via content.find, which is served by a TTL-only cache with no write-invalidation, so rapid sequential block inserts could be handed duplicate IDs. Allocate from a per-course atomic counter ($inc) that bypasses the cache, mirroring friendly ID generation. All tracking-ID logic now lives in this module. Refs cgkineo/adapt-authoring#201
|
🎉 This PR is included in version 1.2.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #36
Fix
insertTrackingIdwith allocation from a per-course atomic counter (findOneAndUpdate$inc), seeded once from the existing max. This bypasses the contentDataCache(which is TTL-only with no write-invalidation), so rapid/sequential block inserts can no longer be handed duplicate_trackingIds — the root cause of Duplicate tracking IDs assigned to blocks #36 / #201._multilangSync) intentionally reuse the source ID and are skipped.contentcounterscollection, so course deletion cleans it up via content's existing sweep — no new collection or index.resetCourseTrackingIdsnow reads/writes Mongo directly (cache-safe) and realigns the counter; it remains the canonical renumber routine.adapt-authoring-mongodbpeer dependency.Breaking
Testing
lib/SpoorTrackingModule.spec.jsrewritten: covers allocation (seed +$inc, contiguous ranges), multilang skip, clone-payload overwrite, reset + counter realignment, and the handler. 16/16 pass;standardclean.