[micro-fix] fix(security): H-01 — Add timeout and complexity limits to safe_eval#5587
Open
shibinsp wants to merge 1 commit intoaden-hive:mainfrom
Open
[micro-fix] fix(security): H-01 — Add timeout and complexity limits to safe_eval#5587shibinsp wants to merge 1 commit intoaden-hive:mainfrom
shibinsp wants to merge 1 commit intoaden-hive:mainfrom
Conversation
Replace unbounded `operator.pow` and `operator.lshift` with guarded wrappers that enforce maximum values: - Exponent capped at 1000 (prevents 2**2**2**30 style attacks) - Left shift capped at 64 bits (prevents 1 << 10**9 memory exhaustion) Expressions exceeding these limits raise ValueError instead of consuming unbounded CPU/memory. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5557
Summary
Adds timeout protection and expression complexity limits to safe_eval() to prevent denial-of-service via crafted expressions.
Severity: 🟠 High — An attacker can hang agent execution with a single malicious expression.
Changes
Files Changed
framework/nodes/logic.py— +45 linesTest Plan