[micro-fix] fix(security): H-02 — Restrict attribute access in safe_eval#5588
Open
shibinsp wants to merge 1 commit intoaden-hive:mainfrom
Open
[micro-fix] fix(security): H-02 — Restrict attribute access in safe_eval#5588shibinsp wants to merge 1 commit intoaden-hive:mainfrom
shibinsp wants to merge 1 commit intoaden-hive:mainfrom
Conversation
Limit visit_Attribute to only allow attribute access on basic Python types (str, int, float, list, dict, tuple, set, etc.). Previously, getattr() was called on arbitrary context objects with only an underscore-prefix check, which could expose dangerous methods or internal state on custom objects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5558
Summary
Blocks dangerous attribute access patterns in safe_eval() that could allow sandbox escape through Python introspection.
Severity: 🟠 High — Attackers could escape the eval sandbox and execute arbitrary code.
Changes
Files Changed
framework/nodes/logic.py— +38 linesTest Plan