[micro-fix] fix(security): H-04 — Replace eval() with json.loads() in memory#5591
Open
shibinsp wants to merge 1 commit intoaden-hive:mainfrom
Open
[micro-fix] fix(security): H-04 — Replace eval() with json.loads() in memory#5591shibinsp wants to merge 1 commit intoaden-hive:mainfrom
shibinsp wants to merge 1 commit intoaden-hive:mainfrom
Conversation
Remove `**memory` from the edge condition evaluation context.
Unpacking arbitrary memory keys directly into the eval namespace
allowed adversarial content to shadow built-in names or inject
unexpected variables into the safe_eval evaluator.
Memory values are still accessible via `memory["key"]` or
`memory.get("key")` in condition expressions.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5560
Summary
Replaces dangerous eval() in memory bank data unpacking with json.loads() to prevent arbitrary code execution.
Severity: 🟠 High — Malicious memory entries could execute arbitrary code during unpacking.
Changes
Files Changed
framework/memory.py— +5/-2 linesTest Plan