Skip to content

fix(credentials): align EnvVarStorage exists with load semantics #5680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshit110927 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(credentials): align EnvVarStorage exists with load semantics #5680

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42cbed9
Return boolean from exists method for credential check
harshit110927 Mar 3, 2026
05ed07c
Add test for empty value handling in EnvVarStorage
harshit110927 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/framework/credentials/storage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def list_all(self) -> list[str]:
def exists(self, credential_id: str) -> bool:
"""Check if credential is available in environment."""
env_var = self._get_env_var_name(credential_id)
return self._read_env_value(env_var) is not None
return bool(self._read_env_value(env_var))

def add_mapping(self, credential_id: str, env_var: str) -> None:
"""
Expand Down
8 changes: 8 additions & 0 deletions core/framework/credentials/tests/test_credential_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,14 @@ def test_delete_raises(self):
with pytest.raises(NotImplementedError):
storage.delete("test")

def test_exists_matches_load_for_empty_value(self):
"""Test exists() and load() stay consistent for empty values."""
storage = EnvVarStorage(env_mapping={"empty": "EMPTY_API_KEY"})

with patch.object(storage, "_read_env_value", return_value=""):
assert storage.load("empty") is None
assert not storage.exists("empty")


class TestEncryptedFileStorage:
"""Tests for EncryptedFileStorage."""
Expand Down