Skip to content

micro-fix: GitGuardian alert: derive credential IDs from fixtures instead of hardcoding#5681

Closed
Taimoor2500 wants to merge 1 commit intoaden-hive:mainfrom
Taimoor2500:main
Closed

micro-fix: GitGuardian alert: derive credential IDs from fixtures instead of hardcoding#5681
Taimoor2500 wants to merge 1 commit intoaden-hive:mainfrom
Taimoor2500:main

Conversation

@Taimoor2500
Copy link

Summary
When forking the repository, GitGuardian reported hardcoded credential-like strings in the Aden sync tests. This PR removes those hardcoded values and derives them from fixtures instead.
Problem
In test_sync_all, the credential ID "aHVic3BvdDp0ZXN0OjEzNjExOjExNTI1" was hardcoded in both the mock data and the assertion. GitGuardian flagged this as a potential secret.
Solution
Use aden_response.integration_id as the single source of truth for the credential ID. The mock and assertion now reference this value instead of repeating the string. Behavior is unchanged; only the way the ID is obtained is different.
Changes
test_sync_all: Replace hardcoded credential ID with aden_response.integration_id in both the mock and the assertion.

@github-actions
Copy link

github-actions bot commented Mar 3, 2026

PR Closed - Requirements Not Met

This PR has been automatically closed because it doesn't meet the requirements.

Missing: No linked issue found.

To fix:

  1. Create or find an existing issue for this work
  2. Assign yourself to the issue
  3. Re-open this PR and add Fixes #123 in the description

Exception: To bypass this requirement, you can:

  • Add the micro-fix label or include micro-fix in your PR title for trivial fixes
  • Add the documentation label or include doc/docs in your PR title for documentation changes

Micro-fix requirements (must meet ALL):

Qualifies Disqualifies
< 20 lines changed Any functional bug fix
Typos & Documentation & Linting Refactoring for "clean code"
No logic/API/DB changes New features (even tiny ones)

Why is this required? See #472 for details.

@github-actions github-actions bot closed this Mar 3, 2026
@Taimoor2500 Taimoor2500 changed the title Fix GitGuardian alert: derive credential IDs from fixtures instead of hardcoding micro-fix: GitGuardian alert: derive credential IDs from fixtures instead of hardcoding Mar 3, 2026
@kostasuser01gr
Copy link
Contributor

Hi @Taimoor2500! I noticed your PR was closed because it was missing a link to the issue. Since your fix is under 20 lines and addresses a bug, it qualifies as a micro-fix.

To get it merged, you just need to:

  1. Update your PR body to include Fixes #5682.
  2. Reopen the PR.

You can do this via the CLI:

gh pr edit 5681 --body "$(gh pr view 5681 --json body -q .body)

Fixes #5682"
gh pr reopen 5681

Hope this helps! — Konstantinos

@Taimoor2500
Copy link
Author

@kostasuser01gr i created a micro-fix pr for this earler link: PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants