Skip to content

fix(shared_state): Make write_batch atomic under SYNCHRONIZED isolation #5953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
namo507 wants to merge 1 commit into from
Closed

fix(shared_state): Make write_batch atomic under SYNCHRONIZED isolation #5953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions core/framework/runtime/shared_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,3 +497,9 @@ def read_all_sync(self) -> dict[str, Any]:
result = {k: v for k, v in result.items() if k in self._allowed_read}

return result


# TODO(fix/atomic-write-batch): write_batch() under SYNCHRONIZED isolation should acquire
# all per-key locks atomically (sorted to prevent deadlock) before writing any values.
# See: https://github.com/aden-hive/hive/issues/5946
# A _write_batch_atomic() method should be added in a follow-up PR.
Loading