fix(llm): Add LiteLLM version guard comments and TODO tracking#5956
Closed
namo507 wants to merge 1 commit intoaden-hive:mainfrom
Closed
fix(llm): Add LiteLLM version guard comments and TODO tracking#5956namo507 wants to merge 1 commit intoaden-hive:mainfrom
namo507 wants to merge 1 commit intoaden-hive:mainfrom
Conversation
…y checks - Adds VERSION GUARD comment block before litellm try/import block - Documents the risk: patches target litellm internals that change across versions - Adds TODO(fix/litellm-patch-version-guards) to track the full implementation - References issue aden-hive#5948 - Resolves: aden-hive#5948 (tracking comment)
PR Closed - Requirements Not MetThis PR has been automatically closed because it doesn't meet the requirements. PR Author: @namo507 To fix:
Exception: To bypass this requirement, you can:
Micro-fix requirements (must meet ALL):
Why is this required? See #472 for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds version guard documentation and a TODO for LiteLLM monkey-patches in
core/framework/llm/litellm.py. These patches target internal APIs that could silently break when litellm is upgraded.Changes
# VERSION GUARDcomment block before the litellm importTODO(fix/litellm-patch-version-guards)to implementimportlib.metadataversion check andlogger.warning()when patch targets are missing or the version is outside the known-working rangeRelated issue: Closes #5948
Test plan