Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(backend/mixins): make AggregateQuerysetMixin more readable #148

Merged
merged 1 commit into from
Jun 17, 2024
Merged

refactor(backend/mixins): make AggregateQuerysetMixin more readable #148

merged 1 commit into from
Jun 17, 2024

Conversation

c0rydoras
Copy link
Collaborator

@c0rydoras c0rydoras commented May 13, 2024 •
edited
Loading

prefetch_related_for_field was dropped because it isn't used anywhere

@c0rydoras c0rydoras self-assigned this May 13, 2024
@c0rydoras c0rydoras requested a review from a team as a code owner May 13, 2024 16:42
@c0rydoras c0rydoras force-pushed the refactor/mixins-querysetaggregatestuff branch 3 times, most recently from c414f85 to 6eaf1ba Compare May 14, 2024 06:51
@c0rydoras c0rydoras added python Pull requests that update Python code backend This issue or pull request is backend related refactor This issue or pull request discusses refactoring labels May 14, 2024
@c0rydoras c0rydoras force-pushed the refactor/mixins-querysetaggregatestuff branch from 6eaf1ba to ec18464 Compare May 14, 2024 09:03
@c0rydoras c0rydoras mentioned this pull request May 14, 2024
Open
1 task
@c0rydoras c0rydoras force-pushed the refactor/mixins-querysetaggregatestuff branch 2 times, most recently from 9cf35da to 286d29b Compare May 14, 2024 14:21
@c0rydoras c0rydoras force-pushed the refactor/mixins-querysetaggregatestuff branch 3 times, most recently from 1a3c9fc to 815c3b8 Compare May 24, 2024 15:57
@c0rydoras c0rydoras force-pushed the refactor/mixins-querysetaggregatestuff branch from 815c3b8 to 9bd3817 Compare June 14, 2024 07:18
@c0rydoras c0rydoras force-pushed the refactor/mixins-querysetaggregatestuff branch from 9bd3817 to 8c44ab4 Compare June 17, 2024 12:04
winged
winged approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@winged winged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work cleaning this up!

@c0rydoras c0rydoras merged commit d333ea0 into adfinis:main Jun 17, 2024
9 checks passed
@c0rydoras c0rydoras deleted the refactor/mixins-querysetaggregatestuff branch June 17, 2024 13:06
MitanOmar pushed a commit to MitanOmar/timed that referenced this pull request Jun 27, 2024
@c0rydoras @MitanOmar
refactor(backend/mixins): make AggregateQuerysetMixin more readable (a…
afc6664 
…dfinis#148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winged winged winged approved these changes

Assignees

@c0rydoras c0rydoras

Labels
backend This issue or pull request is backend related python Pull requests that update Python code refactor This issue or pull request discusses refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c0rydoras @winged