-
Notifications
You must be signed in to change notification settings - Fork 235
chore: command orchestration #5791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
3cd08a9
ffa43cc
1e00ab5
1f1e69e
c57c437
b5ee171
0107b93
85e914c
1b9f9d0
689ffcc
0ee20d4
fce826e
29f4e28
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,108 @@ | ||
| { | ||
| "env": { | ||
| "browser": true, | ||
| "es6": true, | ||
| "node": true | ||
| }, | ||
| "extends": [ | ||
| "eslint:recommended", | ||
| "plugin:@typescript-eslint/recommended", | ||
| "plugin:prettier/recommended" | ||
| ], | ||
| "overrides": [ | ||
| { | ||
| "extends": ["plugin:jsonc/recommended-with-jsonc"], | ||
| "files": ["*.json"], | ||
| "parser": "jsonc-eslint-parser", | ||
| "rules": { | ||
| "jsonc/sort-keys": ["warn"] | ||
| } | ||
| }, | ||
| { | ||
| "extends": ["plugin:jsonc/recommended-with-jsonc"], | ||
| "files": ["package.json"], | ||
| "parser": "jsonc-eslint-parser", | ||
| "rules": { | ||
| "jsonc/sort-keys": [ | ||
| "warn", | ||
| { | ||
| "hasProperties": ["type"], | ||
| "order": [ | ||
| "$schema", | ||
| "name", | ||
| "version", | ||
| "private", | ||
| "description", | ||
| "license", | ||
| "author", | ||
| "maintainers", | ||
| "contributors", | ||
| "homepage", | ||
| "repository", | ||
| "bugs", | ||
| "type", | ||
| "exports", | ||
| "main", | ||
| "module", | ||
| "browser", | ||
| "man", | ||
| "preferGlobal", | ||
| "bin", | ||
| "files", | ||
| "directories", | ||
| "scripts", | ||
| "config", | ||
| "sideEffects", | ||
| "types", | ||
| "typings", | ||
| "workspaces", | ||
| "resolutions", | ||
| "dependencies", | ||
| "bundleDependencies", | ||
| "bundledDependencies", | ||
| "peerDependencies", | ||
| "peerDependenciesMeta", | ||
| "optionalDependencies", | ||
| "devDependencies", | ||
| "keywords", | ||
| "engines", | ||
| "engineStrict", | ||
| "os", | ||
| "cpu", | ||
| "publishConfig" | ||
| ], | ||
| "pathPattern": "^$" | ||
| }, | ||
| { | ||
| "order": { "type": "asc" }, | ||
| "pathPattern": "^(?!exports\\[).*" | ||
| } | ||
| ] | ||
| } | ||
| }, | ||
| { | ||
| "extends": ["./first-gen/.eslintrc.json"], | ||
| "files": ["first-gen/**/*"] | ||
| }, | ||
| { | ||
| "extends": ["./second-gen/.eslintrc.json"], | ||
| "files": ["second-gen/**/*"] | ||
| } | ||
| ], | ||
| "parser": "@typescript-eslint/parser", | ||
| "parserOptions": { | ||
| "ecmaVersion": 2020, | ||
| "sourceType": "module" | ||
| }, | ||
| "plugins": ["@typescript-eslint"], | ||
| "root": true, | ||
| "rules": { | ||
| "no-console": [ | ||
| "error", | ||
| { | ||
| "allow": ["warn", "error"] | ||
| } | ||
| ], | ||
| "no-debugger": 2 | ||
| } | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -15,10 +15,18 @@ | |
| }, | ||
| "type": "module", | ||
| "scripts": { | ||
| "build": "yarn workspace @adobe/spectrum-web-components build", | ||
| "test": "yarn workspace @adobe/spectrum-web-components test", | ||
| "start": "yarn workspace @adobe/spectrum-web-components storybook", | ||
| "lint": "yarn workspace @adobe/spectrum-web-components lint", | ||
| "build-first-gen": "yarn workspace @adobe/spectrum-web-components build", | ||
| "build-second-gen": "yarn workspace @adobe/swc build", | ||
| "build": "yarn build-first-gen && yarn build-second-gen", | ||
|
||
| "test-first-gen": "yarn workspace @adobe/spectrum-web-components test", | ||
| "test-second-gen": "yarn workspace @adobe/swc test", | ||
| "test": "yarn test-first-gen && yarn test-second-gen", | ||
| "start-first-gen": "yarn workspace @adobe/spectrum-web-components start", | ||
| "start-second-gen": "yarn workspace @adobe/swc start", | ||
| "start": "yarn start-first-gen & yarn start-second-gen", | ||
| "lint-first-gen": "yarn workspace @adobe/spectrum-web-components lint", | ||
| "lint-second-gen": "yarn workspace @adobe/swc lint", | ||
| "lint": "yarn lint-first-gen & yarn lint-second-gen", | ||
| "postinstall": "husky || true && patch-package" | ||
| }, | ||
| "workspaces": [ | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| { | ||
| "name": "@adobe/spectrum-web-components-2nd-gen", | ||
| "name": "@adobe/swc", | ||
| "version": "0.0.1", | ||
| "private": true, | ||
| "description": "Second generation Spectrum Web Components with modern tooling and architecture", | ||
|
|
@@ -16,10 +16,10 @@ | |
| }, | ||
| "type": "module", | ||
| "scripts": { | ||
| "build": "yarn workspaces foreach --from '@swc/*' run build", | ||
| "clean": "yarn workspaces foreach --from '@swc/*' run clean", | ||
| "build": "yarn workspaces foreach --from '@swc/*' --recursive run build", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This will force Yarn to traverse downstream dependents, rebuilding or cleaning even when nothing changed. Is this what we need? We can do caching or parallelisation here too. Let me know your setup |
||
| "clean": "yarn workspaces foreach --from '@swc/*' --recursive run clean", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If you just want to delete the SWC output you can avoid the cascading clean. You can just run this? yarn workspaces foreach --from '@swc/*' run clean |
||
| "lint": "eslint . --ext .ts,.js,.json", | ||
| "storybook": "yarn workspace @swc/components storybook", | ||
| "start": "yarn workspace @swc/components storybook", | ||
TarunAdobe marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| "storybook:build": "yarn workspace @swc/components storybook:build", | ||
| "test": "yarn workspace @swc/components test" | ||
| }, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we just use "latest" here or is there a reason we need to use "2020" version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no reason. it was 2020 everywhere else so cursor copied the same thing and i didn't look. will update this to latest and see if nothing breaks