Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build tables separately #4

Open
rzr opened this issue Oct 4, 2019 · 23 comments
Open

Build tables separately #4

rzr opened this issue Oct 4, 2019 · 23 comments

Comments

@rzr
Copy link
Collaborator

rzr commented Oct 4, 2019

It would be good to build tables outside sources, using pinconfig ...
and maintain them in separate repo

@zezinho42
Copy link

Well, as a player, I don't mind. But as an hacker, yes it could be good to be able to test table changes without recompiling.

@rzr
Copy link
Collaborator Author

rzr commented Dec 4, 2019

the reason is that tables can evolve separately and could be composed of unfree contents

@rzr
Copy link
Collaborator Author

rzr commented Dec 23, 2019

Hi dear pinball contributors (@zezinho42, @sergiomb2, @orbea ...)

I have news to share
I managed to build the gnu table independently,
I am considering to create a new repo that can be used as template
can you suggest a better name than "pinball-table-gnu" ?

Beta tests are welcome...

Legacy tables might stay inside pinball main source, but others might evolve on their own repo.

Please help by listing and contacting all pinball data contributors.

Regards and happy EoY

@sergiomb2
Copy link
Contributor

you have all table Licenses here: https://github.com/sergiomb2/pinball/blob/master/License.txt

2) gnu table licenses are (GFDL or Free Art or CC-BY-SA) and GPLv3 and
CC-BY-SA (data/gnu/README)
3) hurd table license is GPLv2+ (data/hurd/README.txt)
4) professor table license is GPLv2+ (data/professor2/README.txt)

@sergiomb2
Copy link
Contributor

Beta tests are welcome...

I'd like test it , where is the code ? please

Thanks

rzr added a commit to adoptware/pinball-table-gnu that referenced this issue Dec 25, 2019
@rzr
Copy link
Collaborator Author

rzr commented Dec 25, 2019

Merry #GMass : a #GNU #pinball table to play with #EmiliaPinball on #GnuLinux (more to come)

https://github.com/rzr/pinball-table-gnu#

rzr added a commit to adoptware/pinball-table-gnu that referenced this issue Dec 25, 2019
@rzr
Copy link
Collaborator Author

rzr commented Dec 30, 2019

Any feedback ? I also plan to relocate code of hurd table ouside main repo and then eventually make a new release, any important patch that should go to master ?

@zezinho42
Copy link

zezinho42 commented Dec 30, 2019

Any feedback ?

Sorry, no time for test here for now...

@rzr
Copy link
Collaborator Author

rzr commented Jan 7, 2020

The hurd table is no more in master branch
does any one want to maintain or co-maintain it like the gnu table ?

@zezinho42
Copy link

The hurd table is no more in master branch
does any one want to maintain or co-maintain it like the gnu table ?

I think I can do that...

@rzr
Copy link
Collaborator Author

rzr commented Jan 8, 2020

Thanks @zezinho42 have you checked

https://github.com/rzr/pinball-table-gnu#

let me push similar "work in progress" I have done on hurd table

@zezinho42
Copy link

Thanks @zezinho42 have you checked
Not yet. It would be handy to have a README file explaining how to build the tables also.

rzr added a commit to adoptware/pinball-table-hurd that referenced this issue Jan 8, 2020
@rzr
Copy link
Collaborator Author

rzr commented Jan 8, 2020

May also ping @paolo-caroni about this "new" project:

https://github.com/rzr/pinball-table-hurd

I also plan to adopt Debian's pinball package and wish we can also submit those 2 new tables as extra packages.

It would be good to see if I missed any valuable patches.

rzr added a commit that referenced this issue Jan 8, 2020
Bug: #4
Signed-off-by: Philippe Coval <[email protected]>
rzr added a commit to adoptware/pinball-table-gnu that referenced this issue Jan 8, 2020
rzr added a commit to adoptware/pinball-table-hurd that referenced this issue Jan 8, 2020
rzr added a commit to adoptware/pinball-table-hurd that referenced this issue Jan 10, 2020
rzr added a commit to adoptware/pinball-table-hurd that referenced this issue Jan 10, 2020
rzr added a commit to adoptware/pinball-table-gnu that referenced this issue May 1, 2020
rzr added a commit to adoptware/pinball-table-gnu that referenced this issue May 31, 2020
rzr added a commit to adoptware/pinball-table-gnu that referenced this issue Jun 1, 2020
rzr added a commit to adoptware/pinball-table-gnu that referenced this issue Jun 1, 2020
@rzr
Copy link
Collaborator Author

rzr commented Jun 1, 2020

Relate-to: adoptware/pinball-table-gnu#3

@rzr
Copy link
Collaborator Author

rzr commented Jun 1, 2020

Following: adoptware/pinball-table-gnu#3

hi @sergiomb2 , thanks for your comment

let me explain again, I don't see any value "to pollute" the engine source code with assets, we have 2 samples tables I think it's enough, tables can evolve in parallels without relying on upstream.

I made those 2 as examples.

Now there is a 3rd one called house , I am the author of it and I didn't distribute it properly, did you distribuate it into fedora? this one is not based on Free contents so it should be mixed along sources, if you did please let me know before cleaning it up, I can rework it too.

Do you know any other tables ?

@sergiomb2
Copy link
Contributor

No,
I just know about gnu, hurd, professor (two versions) and tux [1] .

[1]
https://github.com/sergiomb2/pinball/tree/master/data

@paolo-caroni
Copy link

If I don't remember wrong there was an horror table modification of tux table for windows... but I have to check on the old computer that is still in my parents house.

@rzr
Copy link
Collaborator Author

rzr commented Jan 11, 2021

yea I was the author of this table , some contents are at:

http://rzr.online.fr/games.htm

What about professor2 one

@paolo-caroni
Copy link

Professor 2 is only a graphical improvement of professor, I've never complete the game logic.

@rzr
Copy link
Collaborator Author

rzr commented Jan 13, 2021

may this merged upstream ?

@paolo-caroni
Copy link

I've added my last version to sergiomb repo...
paolo-caroni@8d6aea8

if you want made same effort of Hurd on Professor2 you are obviously welcome.
Also you can improve the game logic if you wish (in that case add your name in copyleft notice too).

@sergiomb2
Copy link
Contributor

one day I'd like copy backgrounds from professor to professor2 and drop professor .

rzr referenced this issue in sergiomb2/pinball Jan 19, 2021
as request by Debian packager
@rzr
Copy link
Collaborator Author

rzr commented Jan 19, 2021

Extra note at:

sergiomb2@2b3d82b

For redhat related issue:

https://bugzilla.redhat.com/show_bug.cgi?id=1290935#

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants