Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Normalise/TimeSeriesScaler reconciliation #2289

Merged
merged 12 commits into from
Nov 5, 2024
Merged

Conversation

TonyBagnall
Copy link
Contributor

@TonyBagnall TonyBagnall commented Nov 1, 2024

Reference Issues/PRs

Fixes #2075

Result of dev discussion at module meeting on 1/11/24. Removes the TimeSeriesScaler, replaced with three classes in the file _rescaler

Normalizer - maps all series onto N(0,1)
Centerer- shifts all series to zero mean
MinMaxScaler - Maps all series onto [0,1]

allows unequal length and multivariate (independent transform for each channel

  • tests
  • API
  • notebook
  • Refactor testing uses of TimeSeriesScaler to Normalizer

not doing here, but I think @dguijo may have wanted it

make invertible

@TonyBagnall TonyBagnall added the transformations Transformations package label Nov 1, 2024
@aeon-actions-bot aeon-actions-bot bot added the enhancement New feature, improvement request or other non-bug code enhancement label Nov 1, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#FEF1BE}{\textsf{enhancement}}$ ].
I would have added the following labels to this PR based on the changes made: [ $\color{#41A8F6}{\textsf{transformations}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@TonyBagnall TonyBagnall marked this pull request as ready for review November 2, 2024 13:36
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@TonyBagnall TonyBagnall changed the title [ENH] normalise reconciliation [ENH] Normalise/TimeSeriesScaler reconciliation Nov 2, 2024
Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think would be nice to add visual examples of series normalized before and after, either unit tests datas or a non normalized ucr one

@TonyBagnall
Copy link
Contributor Author

i think would be nice to add visual examples of series normalized before and after, either unit tests datas or a non normalized ucr one

agreed, after #2279

Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor things

aeon/transformations/collection/_rescale.py Show resolved Hide resolved
aeon/transformations/collection/_rescale.py Outdated Show resolved Hide resolved
aeon/transformations/collection/_rescale.py Outdated Show resolved Hide resolved
aeon/transformations/collection/_rescale.py Outdated Show resolved Hide resolved
aeon/transformations/collection/_rescale.py Outdated Show resolved Hide resolved
aeon/transformations/collection/_rescale.py Outdated Show resolved Hide resolved
aeon/transformations/collection/tests/test_rescaler.py Outdated Show resolved Hide resolved
aeon/transformations/collection/_rescale.py Outdated Show resolved Hide resolved
hadifawaz1999
hadifawaz1999 previously approved these changes Nov 2, 2024
Copy link
Member

@hadifawaz1999 hadifawaz1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but seems a conflict exists

# Conflicts:
#	aeon/testing/estimator_checking/tests/test_check_estimator.py
hadifawaz1999
hadifawaz1999 previously approved these changes Nov 4, 2024
# Conflicts:
#	examples/transformations/preprocessing.ipynb
@MatthewMiddlehurst
Copy link
Member

Normalizer or Normaliser? We have other PRs changing to UK english.

@TonyBagnall
Copy link
Contributor Author

Normalizer or Normaliser? We have other PRs changing to UK english.

which other PRs? I went Normaliser then realised the rest of the toolkit is US English

@TonyBagnall TonyBagnall merged commit f38d62d into main Nov 5, 2024
15 checks passed
@TonyBagnall TonyBagnall deleted the ajb/normalise branch November 5, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, improvement request or other non-bug code enhancement transformations Transformations package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] StandardScalar and Normalise Collection transformers
3 participants