-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Normalise/TimeSeriesScaler reconciliation #2289
Conversation
Thank you for contributing to
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think would be nice to add visual examples of series normalized before and after, either unit tests datas or a non normalized ucr one
agreed, after #2279 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few minor things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but seems a conflict exists
# Conflicts: # aeon/testing/estimator_checking/tests/test_check_estimator.py
# Conflicts: # examples/transformations/preprocessing.ipynb
|
which other PRs? I went Normaliser then realised the rest of the toolkit is US English |
Reference Issues/PRs
Fixes #2075
Result of dev discussion at module meeting on 1/11/24. Removes the TimeSeriesScaler, replaced with three classes in the file _rescaler
Normalizer - maps all series onto N(0,1)
Centerer- shifts all series to zero mean
MinMaxScaler - Maps all series onto [0,1]
allows unequal length and multivariate (independent transform for each channel
not doing here, but I think @dguijo may have wanted it
make invertible