[MNT] Update and consolidate general estimator checks #2377
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final part of AEP 05. As far as I know.
For the most part the all-estimator checks were mostly good, but could use some tidying. Some tests i merged to reduce
fit
calls and to reduce redundancy.check_fit_updates_state
now also checks cloning, to avoid having to fit just to check clone resetsis_fitted
check_set_params
had two tests essentially with a bit of redundancy, these have been mergedcheck_constructor
has the most confusing changes probably. It should mostly the same except all kw params are tested and allcallable
parameters are now allowed as defaults (matching sklearn)