Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Update and consolidate general estimator checks #2377

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

MatthewMiddlehurst
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst commented Nov 21, 2024

Final part of AEP 05. As far as I know.

For the most part the all-estimator checks were mostly good, but could use some tidying. Some tests i merged to reduce fit calls and to reduce redundancy.

  • check_fit_updates_state now also checks cloning, to avoid having to fit just to check clone resets is_fitted
  • check_set_params had two tests essentially with a bit of redundancy, these have been merged
  • check_constructor has the most confusing changes probably. It should mostly the same except all kw params are tested and all callable parameters are now allowed as defaults (matching sklearn)

@aeon-actions-bot aeon-actions-bot bot added maintenance Continuous integration, unit testing & package distribution testing Testing related issue or pull request labels Nov 21, 2024
@aeon-actions-bot
Copy link
Contributor

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].
I have added the following labels to this PR based on the changes made: [ $\color{#2C2F20}{\textsf{testing}}$ ]. Feel free to change these if they do not properly represent the PR.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as draft November 21, 2024 18:15
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review November 21, 2024 21:12
@MatthewMiddlehurst MatthewMiddlehurst merged commit 108948d into main Nov 22, 2024
15 checks passed
@MatthewMiddlehurst MatthewMiddlehurst deleted the mm/testing branch November 22, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Continuous integration, unit testing & package distribution testing Testing related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants