Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Update and consolidate general estimator checks #2377

Merged
merged 4 commits into from
Nov 22, 2024
Merged

[MNT] Update and consolidate general estimator checks #2377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8e2d72c
tidy general estimator tests
MatthewMiddlehurst Nov 21, 2024
61cf9db
Merge remote-tracking branch 'origin/main' into mm/testing
MatthewMiddlehurst Nov 21, 2024
9497eaf
fixes
MatthewMiddlehurst Nov 21, 2024
fd18654
fixes
MatthewMiddlehurst Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aeon/testing/estimator_checking/_estimator_checking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,8 +184,8 @@ class is passed.
>>> results = check_estimator(MockClassifier())

Running specific check for MockClassifier
>>> check_estimator(MockClassifier, checks_to_run="check_clone")
{'check_clone(estimator=MockClassifier())': 'PASSED'}
>>> check_estimator(MockClassifier, checks_to_run="check_get_params")
{'check_get_params(estimator=MockClassifier())': 'PASSED'}
"""
# check if estimator has soft dependencies installed
_check_estimator_deps(estimator)
Expand Down
8 changes: 0 additions & 8 deletions aeon/testing/estimator_checking/_yield_classification_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,9 +154,6 @@ def check_classifier_overrides_and_tags(estimator_class):
f"Override _{method} instead."
)

# axis class parameter is for internal use only
assert "axis" not in estimator_class.__dict__

# Test valid tag for X_inner_type
X_inner_type = estimator_class.get_class_tag(tag_name="X_inner_type")
if isinstance(X_inner_type, str):
Expand All @@ -172,11 +169,6 @@ def check_classifier_overrides_and_tags(estimator_class):
else: # must be a list
assert any([t in valid_unequal_types for t in X_inner_type])

# Must have at least one set to True
multi = estimator_class.get_class_tag(tag_name="capability:multivariate")
uni = estimator_class.get_class_tag(tag_name="capability:univariate")
assert multi or uni

valid_algorithm_types = [
"distance",
"deeplearning",
Expand Down
Loading