Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aepp browser 💣 #1490

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented May 8, 2023

I have trouble detecting the navigation between apps in iframe while migrating to sdk@13 (to detect accounts aepp has access to). Instead of solving this problem, I'm proposing to remove aepp browser completely, keeping only links to other aeternity apps. After removing aepp browser, the only way to connect to app would be reverse iframe on desktop. Maybe later we would introduce a different way to communicate between mobile wallet and aepps (deeplinks?). Also, it solves the problem that aepps registry is down.

Aepps list implementation is moved from https://github.com/aeternity/aepp-base-home-page (would archive it later).

The reasons why the usual iframe approach won't be used:

  • it is less secure for an app to open itself in iframe (for example, google.com can't be opened in iframe)
  • cookies didn't get shared between apps opened in Cordova and default web browser
  • parent frame can't detect navigation between pages inside iframe, so for example, Base aepp can't show the current url correctly
  • there were issues that some APIs wasn't available in iframe, so base aepp need to proxy them (like qr code scanner), it is not available in current app-wallet connection api
  • poor UX: browser inside another browser (if not wrapped with Electron/Cordova)
  • approach was rejected by App Store (in cordova version)

This PR is supported by the Æternity Crypto Foundation

@davidyuk davidyuk requested a review from thepiwo May 8, 2023 07:36
@github-actions
Copy link

github-actions bot commented May 8, 2023

Deployed to https://pr-1490-aepp-base.stg.aepps.com

@thepiwo
Copy link
Contributor

thepiwo commented May 8, 2023

I thought the overall plan is to move more in the direction of aepp browser again? cc @kenodressel

@kenodressel
Copy link
Member

I think this was the general Idea but it seems it brings quite a bit of limitations. Would be nice for the superhero wallet team to explore the limitations above @paolomolo :)

@davidyuk davidyuk force-pushed the feature/remove-aepp-browser branch from a88df67 to 4f63190 Compare May 24, 2023 07:51
@dincho
Copy link
Member

dincho commented Dec 22, 2023

What's the up to date status of this?

@kenodressel
Copy link
Member

Not sure @paolomolo ?

@thepiwo thepiwo removed their request for review February 22, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants