AG-12978 Normalised stacked area nulls and zeroes #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsjroberts
force-pushed
the
AG-12978-normalised-stacked-area
branch
from
b123af1 to
a2fccf0
Compare
lsjroberts
commented
Dec 4, 2024
There was a problem hiding this comment.
Correct – except there should be no marker for ie at 2018.
lsjroberts
commented
Dec 4, 2024
lsjroberts
commented
Dec 4, 2024
lsjroberts
force-pushed
the
AG-12978-normalised-stacked-area
branch
from
a2fccf0 to
d2ffa32
Compare
lsjroberts
commented
Dec 4, 2024
Comment on lines
219
to
218
| // Note - Array.isArray(new Float64Array) is false, and this type is used for stack accumulators | ||
| const valueExtent = typeof value === 'number' ? value : Math.max(...value.map((v) => v ?? 0)); | ||
| const valIdx = valueExtent < 0 ? 0 : 1; | ||
| if (value == null || typeof value !== 'number') continue; |
There was a problem hiding this comment.
The array here looked to just be an accumulator, the actual values are the non-array ones so I believe we can just skip those?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ag-grid.atlassian.net/browse/AG-12978
https://ag-grid.atlassian.net/browse/AG-13341