Introduce an ag-charts-core package
#3328
Conversation
… between community and enterprise
| "dependencies": {}, | ||
| "devDependencies": {}, | ||
| "publishConfig": { | ||
| "access": "public" |
There was a problem hiding this comment.
Can we mark this as private, to avoid accidental publishing?
There was a problem hiding this comment.
My concern was that it may cause issues with the way we publish packages, but I can set it private and we can find out if it does 😅
There was a problem hiding this comment.
Yes, I'd prefer that way around. We publish to the private Verdaccio routinely, so I would hope any issues in that respect should show up there; if ag-charts-core is a devDependency I don't foresee any issue with publishing of dependents either?
On another note, as long as we don't generate a .tgz when nx pack --prod is run, then nothing in the publishing pipeline should care AFAIK
There was a problem hiding this comment.
As a heads-up, I followed up by removing the package and package:verify targets to ensure we don't generate publishable artifacts: 45b0457
A new internal package to share utilities and core functionality between the community and enterprise packages, to improve our tree-shaking abilities.