-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce an ag-charts-core package
#3328
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7b59748
added `ag-charts-core` package to share common utils and core modules…
1a135b2
fix ag-charts-core version
iMoses 137a7fe
cleanup ag-charts-core main tests
iMoses 445c3e1
fix tsconfig.json format
iMoses 6e4d3b8
add README.md for ag-charts-core
iMoses 0253d1c
make `ag-charts-core` package private
iMoses File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| node_modules | ||
| src | ||
| tools | ||
| .npmignore | ||
| .prettierignore | ||
| .swcrc | ||
| .dependency-cruiser.js | ||
| jest.* | ||
| tsconfig.* | ||
| project.json | ||
| .esbuild.* | ||
| .env* | ||
|
|
||
| dist/*.d.ts | ||
| dist/**/*.test.* | ||
| *.map | ||
| *.tgz | ||
|
|
||
| !dist/ | ||
| !dist/package/src | ||
| !dist/types/src | ||
| dist/**/package.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| dist/ | ||
| typings/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| { | ||
| "$schema": "https://json.schemastore.org/swcrc", | ||
| "jsc": { | ||
| "target": "es2017", | ||
| "parser": { | ||
| "syntax": "typescript", | ||
| "decorators": true, | ||
| "dynamicImport": true | ||
| }, | ||
| "transform": { | ||
| "decoratorMetadata": true, | ||
| "legacyDecorator": true | ||
| }, | ||
| "keepClassNames": true, | ||
| "externalHelpers": true, | ||
| "loose": true | ||
| }, | ||
| "module": { | ||
| "type": "es6" | ||
| }, | ||
| "sourceMaps": "inline", | ||
| "exclude": [ | ||
| "jest.config.ts", | ||
| ".*\\.spec.tsx?$", | ||
| ".*\\.test.tsx?$", | ||
| "./src/jest-setup.ts$", | ||
| "./**/jest-setup.ts$", | ||
| ".*.js$" | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| The MIT License | ||
|
|
||
| Copyright (c) 2015-2024 AG GRID LTD | ||
|
|
||
| Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| of this software and associated documentation files (the "Software"), to deal | ||
| in the Software without restriction, including without limitation the rights | ||
| to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| copies of the Software, and to permit persons to whom the Software is | ||
| furnished to do so, subject to the following conditions: | ||
|
|
||
| The above copyright notice and this permission notice shall be included in all | ||
| copies or substantial portions of the Software. | ||
|
|
||
| THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| SOFTWARE. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| # ag-charts-core | ||
|
|
||
| TBD - for internal use only |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| import base, { sonarjsConfig } from '../../eslint.config.mjs'; | ||
|
|
||
| export default [...sonarjsConfig, ...base]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| { | ||
| "name": "ag-charts-core", | ||
| "version": "11.0.3-beta.20250105", | ||
| "description": "Advanced Charting / Charts supporting Javascript / Typescript / React / Angular / Vue", | ||
| "private": true, | ||
| "sideEffects": false, | ||
| "main": "./dist/package/main.cjs.js", | ||
| "types": "./dist/types/src/main.d.ts", | ||
| "module": "./dist/package/main.esm.mjs", | ||
| "exports": { | ||
| ".": { | ||
| "import": "./dist/package/main.esm.mjs", | ||
| "require": "./dist/package/main.cjs.js", | ||
| "types": "./dist/types/src/main.d.ts", | ||
| "default": "./dist/package/main.cjs.js" | ||
| } | ||
| }, | ||
| "scripts": { | ||
| "lint:prune": "npx ts-prune -p tsconfig.lib.json" | ||
| }, | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/ag-grid/ag-charts.git" | ||
| }, | ||
| "keywords": [ | ||
| "chart", | ||
| "charts", | ||
| "data", | ||
| "angular", | ||
| "angular-component", | ||
| "react", | ||
| "react-component", | ||
| "reactjs", | ||
| "vue", | ||
| "vuejs" | ||
| ], | ||
| "author": "AG Grid <[email protected]>", | ||
| "license": "MIT", | ||
| "bugs": { | ||
| "url": "https://github.com/ag-grid/ag-charts/issues" | ||
| }, | ||
| "browserslist": [ | ||
| "> 1%", | ||
| "last 2 versions", | ||
| "not ie >= 0", | ||
| "not ie_mob >= 0", | ||
| "not blackberry > 0", | ||
| "not op_mini all", | ||
| "not operamobile >= 0" | ||
| ], | ||
| "homepage": "https://ag-grid.com/charts/", | ||
| "dependencies": {}, | ||
| "devDependencies": {}, | ||
| "publishConfig": { | ||
| "access": "public" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| { | ||
| "name": "ag-charts-core", | ||
| "$schema": "../../node_modules/nx/schemas/project-schema.json", | ||
| "sourceRoot": "packages/ag-charts-core/src", | ||
| "projectType": "library", | ||
| "targets": { | ||
| "build": { | ||
| "executor": "nx:noop", | ||
| "dependsOn": ["build:types", "build:package"], | ||
| "inputs": [], | ||
| "outputs": [], | ||
| "configurations": { | ||
| "watch": {}, | ||
| "production": {} | ||
| } | ||
| }, | ||
| "build:types": { | ||
| "options": {} | ||
| }, | ||
| "build:package": { | ||
| "options": {} | ||
| }, | ||
| "docs-debug-interfaces": { | ||
| "executor": "ag-charts-generate-code-reference-files:generate", | ||
| "dependsOn": ["ag-charts-generate-code-reference-files:build"], | ||
| "inputs": ["{projectRoot}/src/**/*.ts", { "dependentTasksOutputFiles": "**/*", "transitive": false }], | ||
| "outputs": ["{options.output}"], | ||
| "cache": true, | ||
| "options": { | ||
| "mode": "debug-interfaces", | ||
| "inputs": ["{projectRoot}/src"], | ||
| "output": "dist/{projectRoot}/debug-interfaces.AUTO.json" | ||
| } | ||
| }, | ||
| "docs-resolved-interfaces": { | ||
| "executor": "ag-charts-generate-code-reference-files:generate", | ||
| "dependsOn": ["ag-charts-generate-code-reference-files:build"], | ||
| "inputs": ["{projectRoot}/src/**/*.ts", { "dependentTasksOutputFiles": "**/*", "transitive": false }], | ||
| "outputs": ["{options.output}"], | ||
| "cache": true, | ||
| "options": { | ||
| "mode": "docs-interfaces", | ||
| "inputs": ["{projectRoot}/src"], | ||
| "output": "dist/{projectRoot}/resolved-interfaces.AUTO.json" | ||
| } | ||
| }, | ||
| "lint:eslint": {}, | ||
| "lint:circular": {}, | ||
| "lint:depcruise": {}, | ||
| "lint": { | ||
| "executor": "nx:noop", | ||
| "dependsOn": ["lint:eslint", "lint:circular", "lint:depcruise"], | ||
| "configurations": { | ||
| "fix": {} | ||
| } | ||
| }, | ||
| "pack": { | ||
| "executor": "nx:run-commands", | ||
| "dependsOn": ["build"], | ||
| "inputs": ["allTransitiveOutputs"], | ||
| "outputs": ["{workspaceRoot}/dist/{projectRoot}.tgz"], | ||
| "options": { | ||
| "cwd": "{projectRoot}", | ||
| "parallel": false, | ||
| "commands": ["mkdir -p ../../dist/packages", "yarn pack -f ../../dist/{projectRoot}.tgz"] | ||
| } | ||
| }, | ||
| "pack:extract": { | ||
| "executor": "nx:run-commands", | ||
| "dependsOn": ["pack"], | ||
| "inputs": ["allOutputs"], | ||
| "outputs": ["{workspaceRoot}/dist/packages/contents/ag-charts-core/"], | ||
| "options": { "command": "tools/package/extract-contents.sh {projectRoot}" } | ||
| }, | ||
| "pack:verify": { | ||
| "executor": "nx:run-commands", | ||
| "dependsOn": ["pack:extract"], | ||
| "inputs": ["allOutputs"], | ||
| "options": { | ||
| "commands": ["node tools/package/sanity-check-package.js dist/packages/contents/ag-charts-core/package"] | ||
| } | ||
| } | ||
| }, | ||
| "tags": ["no-batching"] | ||
| } |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| { | ||
| "extends": "../../tsconfig.base.json", | ||
| "compilerOptions": { | ||
| "strict": true, | ||
| "forceConsistentCasingInFileNames": false, | ||
| "noImplicitOverride": true, | ||
| "noPropertyAccessFromIndexSignature": false, | ||
| "noImplicitReturns": false, | ||
| "noFallthroughCasesInSwitch": false, | ||
| "noUnusedParameters": true, | ||
| "noUnusedLocals": true | ||
| }, | ||
| "files": [], | ||
| "include": [], | ||
| "references": [ | ||
| { | ||
| "path": "./tsconfig.lib.json" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "verbatimModuleSyntax": true, | ||
| "types": ["node"] | ||
| }, | ||
| "include": ["src/**/*.ts"], | ||
| "exclude": ["jest.config.ts", "src/**/*.spec.ts", "src/**/*.test.ts", "src/**/test/**"] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "extends": "./tsconfig.json", | ||
| "compilerOptions": { | ||
| "verbatimModuleSyntax": true, | ||
| "types": ["node"], | ||
| "noEmit": true | ||
| }, | ||
| "include": ["src/**/*.ts", "benchmarks/**/*.ts", "jest.config.ts", "jest.setup.ts"] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "extends": "./tsconfig.lib.json", | ||
| "compilerOptions": { | ||
| "declaration": true, | ||
| "emitDeclarationOnly": true, | ||
| "types": ["node"] | ||
| }, | ||
| "include": ["src/**/*.ts"], | ||
| "exclude": ["jest.config.ts", "jest.setup.ts", "src/main-test.ts", "**/*.test.ts", "**/test/**"] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "extends": "./tsconfig.types.json", | ||
| "compilerOptions": {} | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| { | ||
| "extends": "./tsconfig.lib.json", | ||
| "compilerOptions": {} | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we mark this as private, to avoid accidental publishing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My concern was that it may cause issues with the way we publish packages, but I can set it private and we can find out if it does 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'd prefer that way around. We publish to the private Verdaccio routinely, so I would hope any issues in that respect should show up there; if
ag-charts-coreis adevDependencyI don't foresee any issue with publishing of dependents either?On another note, as long as we don't generate a
.tgzwhennx pack --prodis run, then nothing in the publishing pipeline should care AFAIKThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a heads-up, I followed up by removing the
packageandpackage:verifytargets to ensure we don't generate publishable artifacts: 45b0457