-
Notifications
You must be signed in to change notification settings - Fork 16
Identify #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identify #461
Conversation
Visit the preview URL for this PR (updated for commit 141a25c): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "provided by" section was a great idea.
I think that it would be useful to add a graphic to the identified point. Also, "What's here?" seems to make more sense than "What's there?" to me.
Ok. Do you think the method for clicking will hold up to more use cases? I noticed it fires when graphics are clicked to see the pop up which I don't think we want? |
Is this ready for prime time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there's some errors for the esri zoom widget and the branch needs to be updated.
What errors do you see with the zoom? How are they reproduced? I don't see any console errors on a fresh load and geocode zoom. |
still needs
|
I forgot to copy esri assets. It looks good. |
adds identify component