Skip to content

Conversation

steveoh
Copy link
Member

@steveoh steveoh commented Aug 1, 2024

adds identify component

Copy link

github-actions bot commented Aug 1, 2024

Visit the preview URL for this PR (updated for commit 141a25c):
Firebase Preview: https://ut-dts-agrc-atlas-dev-d3e52--feat-identify-dzdbcbk2.web.app
(expires "2024-08-28T21:26:05.634431346Z" )

Copy link
Member

@stdavis stdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "provided by" section was a great idea.

I think that it would be useful to add a graphic to the identified point. Also, "What's here?" seems to make more sense than "What's there?" to me.

@steveoh
Copy link
Member Author

steveoh commented Aug 1, 2024

Ok. Do you think the method for clicking will hold up to more use cases? I noticed it fires when graphics are clicked to see the pop up which I don't think we want?

@steveoh steveoh changed the base branch from main to dev August 2, 2024 05:34
@steveoh steveoh changed the base branch from dev to main August 2, 2024 05:35
@steveoh
Copy link
Member Author

steveoh commented Aug 14, 2024

Is this ready for prime time?

Copy link
Member

@stdavis stdavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there's some errors for the esri zoom widget and the branch needs to be updated.

@steveoh
Copy link
Member Author

steveoh commented Aug 14, 2024

What errors do you see with the zoom? How are they reproduced? I don't see any console errors on a fresh load and geocode zoom.

@steveoh steveoh marked this pull request as ready for review August 14, 2024 17:14
@steveoh
Copy link
Member Author

steveoh commented Aug 14, 2024

still needs

  • a graphic for the identified point
  • look into adding the rac plugin to the preset

@stdavis
Copy link
Member

stdavis commented Aug 14, 2024

I forgot to copy esri assets. It looks good.

@stdavis stdavis merged commit f6a1227 into main Aug 14, 2024
6 checks passed
@stdavis stdavis deleted the feat/identify branch August 14, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants