Identify

.github/workflows/pull_request.yml

@@ -12,6 +12,31 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  test-check:
+    name: Lint and check types
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: ⬇️ Set up code
+        uses: actions/checkout@v4
+        with:
+          show-progress: false
+
+      - name: ⎔ Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: lts/*
+          cache: npm
+
+      - name: 📥 Download dependencies
+        run: npm ci
+
+      - name: 🧶 Lint
+        run: npm run lint
+
+      - name: 🧪 Check types
+        run: npm run check
+
   test-unit:
     name: Unit tests
     runs-on: ubuntu-latest
@@ -37,7 +62,7 @@ jobs:
   deploy-preview:
     name: Firebase preview
     runs-on: ubuntu-latest
-    needs: test-unit
+    needs: [test-unit, test-check]
     if: ${{ github.event.sender.type == 'User' }}
     environment:
       name: preview
@@ -55,5 +80,4 @@ jobs:
         env:
           VITE_DISCOVER: ${{ secrets.VITE_DISCOVER }}
           VITE_WEB_API: ${{ secrets.VITE_WEB_API }}
-          VITE_PRINT_PROXY: ${{ secrets.VITE_PRINT_PROXY }}
           VITE_FIREBASE_CONFIG: ${{ secrets.FIREBASE_CONFIG }}

.github/workflows/push.yml

@@ -84,5 +84,4 @@ jobs:
         env:
           VITE_DISCOVER: ${{ secrets.VITE_DISCOVER }}
           VITE_WEB_API: ${{ secrets.VITE_WEB_API }}
-          VITE_PRINT_PROXY: ${{ secrets.VITE_PRINT_PROXY }}
           VITE_FIREBASE_CONFIG: ${{ secrets.FIREBASE_CONFIG }}

.prettierrc

@@ -0,0 +1,5 @@
+{
+  "plugins": ["prettier-plugin-organize-imports", "prettier-plugin-packagejson", "prettier-plugin-tailwindcss"],
+  "printWidth": 120,
+  "singleQuote": true
+}

.vscode/extensions.json

@@ -0,0 +1,8 @@
+{
+  "recommendations": [
+    "streetsidesoftware.code-spell-checker",
+    "esbenp.prettier-vscode",
+    "bradlc.vscode-tailwindcss",
+    "dbaeumer.vscode-eslint",
+  ]
+}

.vscode/settings.json

@@ -1,39 +1,38 @@
 {
+  "[javascript]": {
+    "editor.defaultFormatter": "esbenp.prettier-vscode"
+  },
   "cSpell.words": [
-    "agrc",
     "apos",
     "arcgis",
     "basemap",
     "browserslist",
     "cadastre",
-    "cbll",
-    "chuhlomin",
     "escaperegexp",
     "esrijs",
     "firebaserc",
+    "geocode",
     "Geospatial",
     "gnis",
     "hostingchannels",
     "lods",
     "noopener",
     "noreferrer",
     "packagejson",
-    "padder",
     "sgid",
     "sitla",
-    "sortby",
     "srid",
     "tagname",
     "tailwindcss",
-    "tibdex",
     "topo",
     "ugrc",
-    "uniqwith",
     "usgs",
     "vite",
-    "wkid",
-    "wonkavision",
-    "wwwroot"
+    "wkid"
   ],
+  "editor.codeActionsOnSave": {
+    "source.organizeImports": "explicit"
+  },
+  "editor.defaultFormatter": "esbenp.prettier-vscode",
   "editor.formatOnSave": true
 }

eslint.config.js

@@ -0,0 +1,54 @@
+import js from '@eslint/js';
+import eslintConfigPrettier from 'eslint-config-prettier';
+import prettier from 'eslint-plugin-prettier';
+import reactPlugin from 'eslint-plugin-react';
+import reactHooks from 'eslint-plugin-react-hooks';
+import globals from 'globals';
+import tseslint from 'typescript-eslint';
+
+// eslint.config.js
+export default tseslint.config(
+  js.configs.recommended,
+  ...tseslint.configs.recommended,
+  {
+    ...reactPlugin.configs.flat.recommended,
+    languageOptions: {
+      ecmaVersion: 2022,
+      sourceType: 'module',
+      ...reactPlugin.configs.flat.recommended.languageOptions,
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+        ...globals.es2022,
+      },
+    },
+    settings: { react: { version: 'detect' } },
+    plugins: {
+      react: reactPlugin,
+      prettier,
+      'react-hooks': reactHooks,
+    },
+    files: ['**/*.{js,mjs,cjs,jsx,mjsx,ts,tsx,mtsx}'],
+    rules: {
+      ...eslintConfigPrettier.rules,
+      ...reactHooks.configs.recommended.rules,
+      ...reactPlugin.configs['jsx-runtime'].rules,
+    },
+  },
+  {
+    ignores: [
+      '.firebase',
+      '.github/*',
+      '.vscode/*',
+      'data/*',
+      'dist/*',
+      'forklift/*',
+      'maps/*',
+      'mockups/*',
+      'node_modules/*',
+      'package-lock.json',
+      'public/*',
+      'scripts/*',
+    ],
+  },
+);

index.html

@@ -3,7 +3,7 @@
   <head>
     <meta charset="utf-8" />
     <link rel="shortcut icon" href="favicon.ico" />
-    <meta name="viewport" content="width=device-width, initial-scale=1, shrink-to-fit=no" />
+    <meta name="viewport" content="width=device-width, initial-scale=1.0, shrink-to-fit=no" />
     <meta
       name="description"
       content="This web mapping application will show you Discover base maps, kitchen sink react components, and the esri javascript api. It is a GitHub template that you can use to create your own."
@@ -17,6 +17,6 @@
   <body class="size-full bg-white text-zinc-700 subpixel-antialiased dark:bg-zinc-800 dark:text-zinc-50">
     <noscript> You need to enable JavaScript to run this app. </noscript>
     <div id="root"></div>
-    <script type="module" src="/src/main.jsx"></script>
+    <script type="module" src="/src/main.tsx"></script>
   </body>
 </html>