Dependencies: Update tabulate~=0.9.0
#6472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6472 +/- ##
==========================================
+ Coverage 77.51% 77.75% +0.25%
==========================================
Files 560 561 +1
Lines 41444 41768 +324
==========================================
+ Hits 32120 32473 +353
+ Misses 9324 9295 -29 ☔ View full report in Codecov by Sentry. |
pyproject.toml
Outdated
| @@ -44,7 +44,7 @@ dependencies = [ | |||
| 'pyyaml~=6.0', | |||
| 'requests~=2.0', | |||
| 'sqlalchemy~=2.0', | |||
| 'tabulate~=0.8.5', | |||
| 'tabulate~=0.9.0', | |||
There was a problem hiding this comment.
Wouldn't it be better for the ecosystem to allow both 0.8 and 0.9?
There was a problem hiding this comment.
Yes it would. For packages that have not seen a v1 release, we have maintained this policy though since minor versions are likely to break things and this will break our release. I guess we could change the specifier to tabulate>=0.8.0,<0.10.0. It is a bit ridiculous that tabulate doesn't have a v1 after more than 10 years of being public...
sphuber
force-pushed
the
fix/6470/dependencies-tabulate
branch
from
236ec4f to
52ec084
Compare
mikibonacci
pushed a commit
to mikibonacci/aiida-core
that referenced
this pull request
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6470