Fixed verdi code export does not return a message if successful #6643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krishnabhujade
changed the title
|
Thanks @Krishnabhujade. I think the original issue was addressed by #6486 with adding the line where you made the change in this PR. |
unkcpz
reviewed
Nov 28, 2024
| @@ -274,7 +274,7 @@ def export(code, output_file, overwrite, sort): | |||
| except Exception as exception: | |||
| echo.echo_critical(f'Error in the `data_export` function: {exception}') | |||
|
|
|||
| echo.echo_success(f'Code<{code.pk}> {code.label} exported to file `{output_file}`.') | |||
| echo.echo_success(f"Success: Code '{code.label}' (ID: {code.pk}) exported to file '{output_file}'.") | |||
There was a problem hiding this comment.
The echo_success function call will put a "Success" in the command output, so it is not necessary to have "Success:" in front.
There was a problem hiding this comment.
Thanks for the feedback! I see that #6486 addressed this, and I’ll update my PR to align with it. Appreciate the clarification also I'm new to open source and working on good first issues I would appreciate any guidance on [specific problem]. Thanks for your help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes "the verdi code export does not return a message if successful"
After the changes now it returns a Successful message
Fixes #6421