Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed verdi code export does not return a message if successful #6643

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed verdi code export does not return a message if successful #6643

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01a6932
verdi code export does not return a message if successful
Krishnabhujade Nov 28, 2024
7cb1bd2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/aiida/cmdline/commands/cmd_code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ def export(code, output_file, overwrite, sort):
except Exception as exception:
echo.echo_critical(f'Error in the `data_export` function: {exception}')

echo.echo_success(f'Code<{code.pk}> {code.label} exported to file `{output_file}`.')
echo.echo_success(f"Success: Code '{code.label}' (ID: {code.pk}) exported to file '{output_file}'.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The echo_success function call will put a "Success" in the command output, so it is not necessary to have "Success:" in front.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I see that #6486 addressed this, and I’ll update my PR to align with it. Appreciate the clarification also I'm new to open source and working on good first issues I would appreciate any guidance on [specific problem]. Thanks for your help



@verdi_code.command()
Expand Down