-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Drop workaround to pass pymatgen related failed tests #6694
Conversation
10b5462
to
99d663c
Compare
I don't know if I did it right with uv, I delete uv and rerun My understanding was the uv will not override the version that is already in the lock file even there are new version of some dependencies out there, it require to remove the lockfile and rerun from scratch to get everything updated, correct? If so (I may totally wrong) we may need a bot to generate lock file periodically for us. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6694 +/- ##
=======================================
Coverage 77.99% 77.99%
=======================================
Files 563 563
Lines 41761 41761
=======================================
Hits 32567 32567
Misses 9194 9194 ☔ View full report in Codecov by Sentry. |
To update a single package in the lockfile, you can run
To update all packages in the lockfile, run:
That's awesome. 🎉 |
The failing test might be due to ipython update, please try to update only the monty dependency. |
3a6eb94
to
de537b1
Compare
@danielhollas, I revert the uv.lock and run with only upgrade monty, all works now. But I think IPython failed test is worth to check. I'll open a PR to manifest the issue. This one is ready to go. |
@unkcpz would you mind updating your uv installation to the latest version? ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!!!
Thanks @danielhollas |
materialsproject/pymatgen#4243 they also make a release for py3.9, so we don't need to have this workaround.