Skip to content

Remove upstream FreeFlow's website, unused images and speech-recognition prompt, and sign ad hoc by default - #105

Merged
ajbarryiii merged 2 commits into
mainfrom
cleanup/freeflow-leftovers
Nov 3, 2026
Merged

ajbarryiii merged 2 commits into
mainfrom
cleanup/freeflow-leftovers

Conversation

@ajbarryiii

@ajbarryiii ajbarryiii commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner

LocalFlow still carried pieces of upstream FreeFlow that it never uses. website/ was FreeFlow's landing page, advertising API calls and AI cleanup that LocalFlow doesn't have. Info.plist declared a speech-recognition usage string, though nothing uses Apple's Speech framework. The Makefile's default signing identity was "FreeFlow Dev", a certificate that doesn't exist on the release Mac, so a plain make failed at the codesign step. The bug and PR templates still asked about providers, models and Keychain credentials.

This removes website/, the three unused images in Resources/ (demo.gif, dmg-background.png, dmg-background@2x.png; the DMG uses dmg-background.tiff, which stays), the NSSpeechRecognitionUsageDescription key and the Makefile line that rewrote it, the bug form's "Provider and model" field, and the docs/README.md sentence about website/. The PR template's provider and Keychain items become one item about logging, persisting or sending user content. The updater's temporary download is now named LocalFlow.dmg. CODESIGN_IDENTITY now defaults to - (ad hoc), which README and AGENTS.md already tell people to pass.

Kept on purpose: the FreeFlow-LICENSE copy and the "Based on FreeFlow" credit (the MIT license requires the attribution), the FreeFlow.entitlements file name (the release script passes it), and the FreeFlowBuildTag Info.plist key (the updater and release workflow read it).

High-risk areas. Signing: the default identity changes from "FreeFlow Dev" to ad hoc. Both release workflows and the local release script pass CODESIGN_IDENTITY explicitly, so releases are unchanged; only a make without the argument changes, from failing to signing ad hoc. Permissions: the speech-recognition usage string is gone, and nothing requests that permission. Updater: only the temporary file's name changes. No privacy, storage, migration or release-note changes.

Proof: CI passes make check, the iOS checks and the Linux checks on this commit. On the Mac, a make without CODESIGN_IDENTITY built a bundle that is signed ad hoc with the hardened runtime and the microphone entitlement, passes codesign --verify --deep --strict, and has no speech-recognition key in its Info.plist. Signing a copy with the old "FreeFlow Dev" default failed with "no identity found".

Manual test: pending. Install an update through the in-app updater on a build from this branch, to confirm the renamed download still mounts and installs.

Commit c5b8739, added during reconciliation, finishes the leftovers in this PR's files:

  • The updater's temporary download folder is now localflow-update-<uuid>. Nothing cleans it up by name.
  • The bug form drops the Intel/Apple Silicon question, since LocalFlow builds for Apple Silicon only.
  • Its macOS example is now 26.1, since 26.0 is the minimum.
  • Its permission hint no longer mentions Screen Recording, which LocalFlow doesn't use.

The reconciliation commit was reviewed by Sol: 1 round, no findings.

Reconciled with #105–#112. Every pair, and the full set, merge onto main without conflicts, so they can merge in any order. All eight merged together pass make check and git diff --check on the Mac. The seven other than #112 also pass make -C iOS check together; #112 changes no file the iOS build compiles.

Created with Claude Opus 5.5 in T3 Code.

Sol Loop: 1 round, 0 fixes (0 high, 0 medium, 0 low, 0 rejected)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant