Repository navigation
Remove upstream FreeFlow's website, unused images and speech-recognition prompt, and sign ad hoc by default - #105
Merged
Merged
Conversation
…ion prompt, and sign ad hoc by default
…to Apple Silicon Macs on macOS 26
This was referenced Nov 3, 2026
Merged
ajbarryiii
marked this pull request as ready for review
November 3, 2026 01:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalFlow still carried pieces of upstream FreeFlow that it never uses.
website/was FreeFlow's landing page, advertising API calls and AI cleanup that LocalFlow doesn't have. Info.plist declared a speech-recognition usage string, though nothing uses Apple's Speech framework. The Makefile's default signing identity was "FreeFlow Dev", a certificate that doesn't exist on the release Mac, so a plainmakefailed at the codesign step. The bug and PR templates still asked about providers, models and Keychain credentials.This removes
website/, the three unused images inResources/(demo.gif,dmg-background.png,dmg-background@2x.png; the DMG usesdmg-background.tiff, which stays), theNSSpeechRecognitionUsageDescriptionkey and the Makefile line that rewrote it, the bug form's "Provider and model" field, and thedocs/README.mdsentence aboutwebsite/. The PR template's provider and Keychain items become one item about logging, persisting or sending user content. The updater's temporary download is now namedLocalFlow.dmg.CODESIGN_IDENTITYnow defaults to-(ad hoc), which README and AGENTS.md already tell people to pass.Kept on purpose: the
FreeFlow-LICENSEcopy and the "Based on FreeFlow" credit (the MIT license requires the attribution), theFreeFlow.entitlementsfile name (the release script passes it), and theFreeFlowBuildTagInfo.plist key (the updater and release workflow read it).High-risk areas. Signing: the default identity changes from "FreeFlow Dev" to ad hoc. Both release workflows and the local release script pass
CODESIGN_IDENTITYexplicitly, so releases are unchanged; only amakewithout the argument changes, from failing to signing ad hoc. Permissions: the speech-recognition usage string is gone, and nothing requests that permission. Updater: only the temporary file's name changes. No privacy, storage, migration or release-note changes.Proof: CI passes
make check, the iOS checks and the Linux checks on this commit. On the Mac, amakewithoutCODESIGN_IDENTITYbuilt a bundle that is signed ad hoc with the hardened runtime and the microphone entitlement, passescodesign --verify --deep --strict, and has no speech-recognition key in its Info.plist. Signing a copy with the old "FreeFlow Dev" default failed with "no identity found".Manual test: pending. Install an update through the in-app updater on a build from this branch, to confirm the renamed download still mounts and installs.
Commit c5b8739, added during reconciliation, finishes the leftovers in this PR's files:
localflow-update-<uuid>. Nothing cleans it up by name.The reconciliation commit was reviewed by Sol: 1 round, no findings.
Reconciled with #105–#112. Every pair, and the full set, merge onto main without conflicts, so they can merge in any order. All eight merged together pass
make checkandgit diff --checkon the Mac. The seven other than #112 also passmake -C iOS checktogether; #112 changes no file the iOS build compiles.Created with Claude Opus 5.5 in T3 Code.
Sol Loop: 1 round, 0 fixes (0 high, 0 medium, 0 low, 0 rejected)