Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): implements ui auto top up toggle #782

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

ygrishajev
Copy link
Contributor

@ygrishajev ygrishajev commented Feb 4, 2025

refs #714
image
image

@ygrishajev ygrishajev requested a review from a team as a code owner February 4, 2025 12:45
@codecov-commenter
Copy link

codecov-commenter commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@da90e52). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../deployment/repositories/lease/lease.repository.ts 0.00% 4 Missing and 1 partial ⚠️
...s/deployment-setting/deployment-setting.service.ts 93.10% 2 Missing ⚠️
...s/hono-error-handler/hono-error-handler.service.ts 83.33% 1 Missing ⚠️
...draining-deployment/draining-deployment.service.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #782   +/-   ##
=======================================
  Coverage        ?   51.51%           
=======================================
  Files           ?      206           
  Lines           ?     4672           
  Branches        ?      692           
=======================================
  Hits            ?     2407           
  Misses          ?     2091           
  Partials        ?      174           
Flag Coverage Δ
api 51.51% <83.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@baktun14 baktun14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

also mocks Lease in deployment settings spec to avoid errors related to missing chain db migrations

refs #714
@ygrishajev ygrishajev merged commit f03df32 into main Feb 5, 2025
6 checks passed
@ygrishajev ygrishajev deleted the feature/deployment branch February 5, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants