Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove comment about potential deprecation of the use-app-time config #483

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

sebastian-alfers
Copy link
Contributor

No description provided.

@@ -371,8 +371,6 @@ akka.persistence.r2dbc {
# Ignored for H2
db-timestamp-monotonic-increasing = off

# Enable this for testing or workaround of https://github.com/yugabyte/yugabyte-db/issues/10995
# FIXME: This property will be removed when the Yugabyte issue has been resolved.
# Ignored for H2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add description:

# Enable this to generate timestamps from the Akka client side instead of using database timestamps.
# NTP or similar clock synchronization should be used, but some clock skew between clients is accepted.
# Ignored for H2

Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@patriknw patriknw merged commit f79bb14 into akka:main Nov 29, 2023
6 checks passed
@patriknw patriknw added this to the 1.2.1 milestone Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants