Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove comment about potential deprecation of the use-app-time config #483

Merged
merged 2 commits into from
Nov 29, 2023
Merged

chore: remove comment about potential deprecation of the use-app-time config #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebf510a
chore: remove comment about potential deprecation of the use-app-time…
sebastian-alfers Nov 29, 2023
81d4621
add recommended config comment
sebastian-alfers Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/resources/reference.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,8 +371,8 @@ akka.persistence.r2dbc {
# Ignored for H2
db-timestamp-monotonic-increasing = off

# Enable this for testing or workaround of https://github.com/yugabyte/yugabyte-db/issues/10995
# FIXME: This property will be removed when the Yugabyte issue has been resolved.
# Enable this to generate timestamps from the Akka client side instead of using database timestamps.
# NTP or similar clock synchronization should be used, but some clock skew between clients is accepted.
# Ignored for H2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add description:

# Enable this to generate timestamps from the Akka client side instead of using database timestamps.
# NTP or similar clock synchronization should be used, but some clock skew between clients is accepted.
# Ignored for H2

use-app-timestamp = off

Expand Down
1 change: 0 additions & 1 deletion core/src/main/scala/akka/persistence/r2dbc/R2dbcSettings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ object R2dbcSettings {

val dbTimestampMonotonicIncreasing: Boolean = config.getBoolean("db-timestamp-monotonic-increasing")

// FIXME remove when https://github.com/yugabyte/yugabyte-db/issues/10995 has been resolved
val useAppTimestamp: Boolean = config.getBoolean("use-app-timestamp")

val logDbCallsExceeding: FiniteDuration =
Expand Down