Update jquery.dynatable.js #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. I changed single quotes to double quotes. This wasn't getting an error but loads of warnings.
2. I've got a dynatable with several filters. Each filter has been populated with certain values + empty string to allow users to select all or just some of them. If I select a value in the first filter and leave the other filters blank it works fine. But if I leave the first filter empty and I select a value in any of the others filters the table doesn't finish loading because there is an error. Where? in the line 1553 (Cannot convert undefined or null to object) it tries to delete from the urlOptions an undefined object.
You need to check if label is undefined before trying to delete it, line 1553: if (typeof urlOptions[label] === "undefined"){ urlOptions[label] = {}; }
I added this condition in line 1564 because I think It could happen too.
What do you think? :)
Looking forward to hearing from you soon.
Regards,
Aixa
|
Hi @AixaMartinez! I'm helping @JangoSteve with Dynatable. We're getting ready to move forward with a lot of overdue work. We're having a meeting about all open PRs next week. We do require that all contributors sign the CLA. Are you available to do so? |
|
Any hope of getting this fix in somehow? This bug prevents use of multiple filters. |
|
Hello @JangoSteve. I missed the message you sent a while ago. If you still want to work on this I'm happy to sign the CLA. Just let me know how to proceed. Regards, Aixa |
|
Hello @mlangens. I missed the message you sent a while ago. If you still want to work on this I'm happy to sign the CLA. Just let me know how to proceed. Regards, Aixa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You need to check if label is undefined before trying to delete it, line 1553: if (typeof urlOptions[label] === "undefined"){ urlOptions[label] = {}; }
I added this condition in line 1564 because I think It could happen too.
What do you think? :)
Looking forward to hearing from you soon.
Regards,
Aixa