Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update jquery.dynatable.js #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update jquery.dynatable.js #190

wants to merge 1 commit into from

Commits on Apr 22, 2015

  1. Update jquery.dynatable.js 

    1. I changed single quotes to double quotes. This wasn't getting an error but loads of warnings.
2. I've got a dynatable with several filters. Each filter has been populated with certain values + empty string to allow users to select all or just some of them. If I select a value in the first filter and leave the other filters blank it works fine. But if I leave the first filter empty and I select a value in any of the others filters the table doesn't finish loading because there is an error. Where? in the line 1553 (Cannot convert undefined or null to object) it tries to delete from the urlOptions an undefined object.

You need to check if label is undefined before trying to delete it, line 1553: if (typeof urlOptions[label] === "undefined"){ urlOptions[label] = {}; }
I added this condition in line 1564 because I think It could happen too.

What do you think? :)

Looking forward to hearing from you soon.

Regards,

Aixa
    @AixaMartinez
    AixaMartinez committed Apr 22, 2015
    Configuration menu
    Copy the full SHA
    f6b9c4c View commit details
    Browse the repository at this point in the history