[feat] refactor embedding group input tile and dense embedding collection #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yjjinjie
reviewed
Dec 27, 2024
yjjinjie
reviewed
Dec 27, 2024
eric-gecheng
approved these changes
Dec 30, 2024
yjjinjie
reviewed
Jan 2, 2025
There was a problem hiding this comment.
这个改动是为什么？ 如果在input-tile=3的情况下，item 已经被等同于 origin的了，那修改的也应该是write_mapping_file_for_input_tile
| item_kt = batch.dense_features.get(key + "_item", None) | ||
| if user_kt is not None or item_kt is not None: | ||
| batch.dense_features[key] = _tile_and_combine_dense_kt( | ||
| user_kt, item_kt, batch.batch_size |
There was a problem hiding this comment.
把dense 的user/item 合并起来，这个会增加一定的计算量
| emb_bag_config=emb_bag_config, | ||
| if need_input_tile_emb and feature.is_user_feat: | ||
| _add_embedding_bag_config( | ||
| emb_bag_configs=mc_emb_bag_configs_user |
There was a problem hiding this comment.
mc_emb_bag_configs_user 又是什么？
| ) | ||
| kts.append(non_emb_dense_features) | ||
|
|
||
| kts.append(self.dense_ec(dense_feature)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.