Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] refactor embedding group input tile and dense embedding collection #75

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor proto and add tests
tiankongdeguiji committed Dec 27, 2024
commit 855d4d0c260c132ec5ae9cd4850cc853c34ccc18
2 changes: 1 addition & 1 deletion tzrec/features/raw_feature.py
Original file line number Diff line number Diff line change
@@ -83,7 +83,7 @@ def dense_emb_config(
dense_emb_type = self.config.WhichOneof("dense_emb")
if dense_emb_type:
dense_emb_config = getattr(self.config, dense_emb_type)
if hasattr(self.config, "value_dim") and self.config.value_dim > 1:
if self.config.value_dim > 1:
return ValueError(
"autodis and mlp embedding do not support feature "
f"[{self.name}] with value dim > 1 now."