fix: incorrectly formatted URLs #364
Conversation
|
It has been almost a year since I filed this pull request, yet not a single word from maintainers. Thousands of projects still rely on this tool, yet doing the bare minimum of keeping the project alive is too hard? Come on... |
Life has got in the way for most of us. And a project of this size is hard to maintain solo when life throws plenty of stuff at you (and you don't want to burn out again due to coding for a living, and then on the side, whilst having many other responsibilities). If you still think this PR helps, then I'm happy to reopen it and merge it. |
|
No worries, haven't tested it though since PR was filed |
What: Fixed a bug where URLs may be malformed and an additonal bug which improved CLS on generated files
Why: Newer GitHub URLs may come with a ?v=4 query already, making these URLs malformed causing errors and incorrect sizings. This will size images properly, saving on data and web load times. There is also a fix to reduce the CLS by defining the width and height of the image.
How: URLs are being formatted with the URL class to ensure URL safety.
Checklist: