This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Fix useDefaultGroups option in Groups module
#4280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs (http://visjs.org/docs/network/groups.html#) indicate that if `useDefaultGroups` is passed as false, it will iterate through the provided groups to use as defaults instead. But the code doesn't seem to match that description, as `useDefaultGroups` is ignored, and the code that handles it being false doesn't seem quite right (it should fetch the full group, not just the color)
29 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs (http://visjs.org/docs/network/groups.html#) indicate that if
useDefaultGroupsis passed as false, it will iterate through the provided groups to use as defaults instead. But the code doesn't seem to match that description, asuseDefaultGroupsis ignored, and the code that handles it being false doesn't seem quite right (it should fetch the full group, not just the color)