Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .check_parameters() method from signatures. #86

Merged
merged 1 commit into from
May 17, 2024

Conversation

jfng
Copy link
Member

@jfng jfng commented May 17, 2024

Since RFC 38, the signature of a component can only be assigned within its constructor. It is no longer useful to decouple the validation of signature parameters from its constructor.

Since RFC 38, the signature of a component can only be assigned within
its constructor. It is no longer useful to decouple the validation of
signature parameters from its constructor.
@jfng jfng enabled auto-merge May 17, 2024 13:50
@jfng jfng added this pull request to the merge queue May 17, 2024
Merged via the queue into amaranth-lang:main with commit 58d7a69 May 17, 2024
12 checks passed
@jfng jfng deleted the remove-check-params branch May 17, 2024 13:54
Copy link
Member

@whitequark whitequark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants